Bug 1829737

Summary: Migrate operator controllers to library-go controller factory
Product: OpenShift Container Platform Reporter: Michal Fojtik <mfojtik>
Component: Etcd OperatorAssignee: Sam Batschelet <sbatsche>
Status: CLOSED ERRATA QA Contact: ge liu <geliu>
Severity: low Docs Contact:
Priority: medium    
Version: 4.5   
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:32:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michal Fojtik 2020-04-30 08:55:11 UTC 
Description of problem:

Etcd operator controllers are hand written and not error prone.
Moving them to factory guarantee the graceful shutdown of each individual controller.
It also remove a lot of boiler plate code we use to make controllers as well as making sure all informers have event handlers registered and we properly wait for every informer cache sync.


Version-Release number of selected component (if applicable):


How reproducible:

This is refactoring/stabilization and there is nothing to reproduce.


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

QE: After the https://github.com/openshift/cluster-etcd-operator/pull/324 land, we can verify this BZ just by running standard regression suite against etcd operator (all tests) to make sure nothing regressed, there is no new test needed.
Comment 3 ge liu 2020-05-26 10:06:07 UTC 
Verified with 4.5.0-0.nightly-2020-05-25-012559, run some regression and passed without err.
Comment 4 errata-xmlrpc 2020-07-13 17:32:59 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409