Bug 183041

Summary: Review Request: perl-Kwiki-ModPerl
Product: [Fedora] Fedora Reporter: Steven Pritchard <steve>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-03-15 23:59:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 183040    
Bug Blocks: 163779    

Description Steven Pritchard 2006-02-25 18:56:01 UTC 
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Kwiki-ModPerl/perl-Kwiki-ModPerl.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Kwiki-ModPerl-0.09-1.src.rpm
Description:
Kwiki mod_perl plugin.
Comment 1 Steven Pritchard 2006-02-27 22:59:31 UTC 
http://ftp.kspei.com/pub/steve/rpms/perl-Kwiki-ModPerl-0.09-2.src.rpm

* Mon Feb 27 2006 Steven Pritchard <steve> 0.09-2
- Drop explicit BR: perl.
Comment 2 Jason Tibbitts 2006-03-02 17:39:23 UTC 
Not much more to say here.  Summary needs fixing, but otherwise everything is
fine.   The Requires: perl(Kwiki) >= 0.32 is unnecessary as RPM will find the
Kwiki dependency and no older version exists in extras.  Interestingly, RPM
doesn't find the mod_perl2 requirement.

Approved; please supply a better summary when you check in.
Comment 3 Paul Howarth 2006-03-02 17:49:47 UTC 
(In reply to comment #2)
> The Requires: perl(Kwiki) >= 0.32 is unnecessary as RPM will find the
> Kwiki dependency and no older version exists in extras.

Whilst the versioned perl(Kwiki) dep doesn't need to be versioned for Extras, it
may be useful for those people that rebuild Extras packages for different
distributions (not an uncommon thing). It might be argued that adding a
versioned dep clutters the spec file but I think that it's a personal preference
issue for the maintainer rather than something that should be fixed. IMHO.
Comment 4 Jason Tibbitts 2006-03-02 17:53:43 UTC 
Sorry, I meant to indicate explicitly that this wasn't a blocker, as I did in my
other review.  I just wanted to point out that RPM will find the perl(Kwiki)
dependency on its own so there's no need to list it.

The package is approved in any case.
Comment 5 Steven Pritchard 2006-03-02 18:00:11 UTC 
For the record, those versioned deps are generated by cpanspec.  (Try "cpanspec
-v Kwiki::ModPerl" if you want to see exactly what I was working from.)  I
usually don't trim them, even if they aren't strictly necessary.  I usually do
remove non-versioned deps, and Core module dependencies are automatically
removed by cpanspec.