Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Kwiki-ModPerl/perl-Kwiki-ModPerl.spec SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Kwiki-ModPerl-0.09-1.src.rpm Description: Kwiki mod_perl plugin.
http://ftp.kspei.com/pub/steve/rpms/perl-Kwiki-ModPerl-0.09-2.src.rpm * Mon Feb 27 2006 Steven Pritchard <steve> 0.09-2 - Drop explicit BR: perl.
Not much more to say here. Summary needs fixing, but otherwise everything is fine. The Requires: perl(Kwiki) >= 0.32 is unnecessary as RPM will find the Kwiki dependency and no older version exists in extras. Interestingly, RPM doesn't find the mod_perl2 requirement. Approved; please supply a better summary when you check in.
(In reply to comment #2) > The Requires: perl(Kwiki) >= 0.32 is unnecessary as RPM will find the > Kwiki dependency and no older version exists in extras. Whilst the versioned perl(Kwiki) dep doesn't need to be versioned for Extras, it may be useful for those people that rebuild Extras packages for different distributions (not an uncommon thing). It might be argued that adding a versioned dep clutters the spec file but I think that it's a personal preference issue for the maintainer rather than something that should be fixed. IMHO.
Sorry, I meant to indicate explicitly that this wasn't a blocker, as I did in my other review. I just wanted to point out that RPM will find the perl(Kwiki) dependency on its own so there's no need to list it. The package is approved in any case.
For the record, those versioned deps are generated by cpanspec. (Try "cpanspec -v Kwiki::ModPerl" if you want to see exactly what I was working from.) I usually don't trim them, even if they aren't strictly necessary. I usually do remove non-versioned deps, and Core module dependencies are automatically removed by cpanspec.