Bug 1830987
| Summary: | forms should not exceed 650px in width. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Matt <mcarleto> | ||||
| Component: | Console Kubevirt Plugin | Assignee: | Yaacov Zamir <yzamir> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Radim Hrazdil <rhrazdil> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.5 | CC: | aos-bugs, rhrazdil, yzamir | ||||
| Target Milestone: | --- | ||||||
| Target Release: | 4.5.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Cause:
When using the wizard in CNV the form inside of it takes up the available width
Consequence:
not align with OCP forms
Fix:
Set wizard form width
Result:
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-07-13 17:34:39 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Matt
2020-05-04 12:46:21 UTC
Note: After discussion in the PR [1] we decided to set width only to "general" tab of the wizard. Reasoning was: a - only "general" and "cloud init" tabs of the wizards are forms the need alignment with OCP guidelines. b - "cloud init" form is a special case, because it does not contain text inputs that will span full width, making it align with OCP without limiting it's width. https://github.com/openshift/console/pull/5475 I compared the width of our Virtualization Wizard and other forms that are in the Console and found out that our Wizard is a little bit narrower than other. It may be caused by the side navigation panel? I'll provide screenshots with VM Wizard and Route form so you can take a look. Created attachment 1690981 [details]
screenshots
Yes, It's a combination of the wizards css class that has it's own padding + the padding of the console form css class that has it's own padding ... Fixing it require to play with the wizard css class (touching the console form css is our of our scope) ... Was afraid to do if because I didn't know what else may change :-( Understood. Since this BZ is about limiting the max-width, I'm moving this to verified. I'll open a new BZ about Wizard form being narrower than others. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |