Bug 1830987 - forms should not exceed 650px in width.
Summary: forms should not exceed 650px in width.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.5.0
Assignee: Yaacov Zamir
QA Contact: Radim Hrazdil
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-04 12:46 UTC by Matt
Modified: 2020-07-13 17:34 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: When using the wizard in CNV the form inside of it takes up the available width Consequence: not align with OCP forms Fix: Set wizard form width Result:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:34:39 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshots (9.46 MB, application/zip)
2020-05-22 07:21 UTC, Radim Hrazdil
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 5475 0 None closed Bug 1830987: Add console form class to vm wizard tab pages 2020-06-24 01:34:41 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:34:57 UTC

Description Matt 2020-05-04 12:46:21 UTC
Description of problem:
When using the wizard in CNV the form inside of it takes up the available width To better align with OCP we should change this so any form in the wizard content area should have a max-width of 650px.

see more info here
http://openshift.github.io/openshift-origin-design/designs/administrator/4.0/forms/#fields

This is seen when doing the following actions with a wzard:
Creating a new VM
Importing a VM
Creating a VM From a template

Comment 1 Yaacov Zamir 2020-05-19 19:36:50 UTC
Note:

After discussion in the PR [1] we decided to set width only to "general" tab of the wizard.

Reasoning was:
a - only "general" and "cloud init" tabs of the wizards are forms the need alignment with OCP guidelines.
b - "cloud init" form is a special case, because it does not contain text inputs that will span full width, making it align with OCP without limiting it's width.

https://github.com/openshift/console/pull/5475

Comment 4 Radim Hrazdil 2020-05-22 07:20:56 UTC
I compared the width of our Virtualization Wizard and other forms that are in the Console and found out that our Wizard is a little bit narrower than other.
It may be caused by the side navigation panel? I'll provide screenshots with VM Wizard and Route form so you can take a look.

Comment 5 Radim Hrazdil 2020-05-22 07:21:46 UTC
Created attachment 1690981 [details]
screenshots

Comment 6 Yaacov Zamir 2020-05-22 12:08:51 UTC
Yes, It's a combination of the wizards css class that has it's own padding + the padding of the console form css class that has it's own padding ...
Fixing it require to play with the wizard css class (touching the console form css is our of our scope) ... 
Was afraid to do if because I didn't know what else may change :-(

Comment 7 Radim Hrazdil 2020-05-22 12:34:24 UTC
Understood. Since this BZ is about limiting the max-width, I'm moving this to verified.
I'll open a new BZ about Wizard form being narrower than others.

Comment 8 errata-xmlrpc 2020-07-13 17:34:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.