Bug 1831603

Summary: [Metal] Support baremetal Reboot API
Product: OpenShift Container Platform Reporter: Nir <nyehia>
Component: Bare Metal Hardware ProvisioningAssignee: Nir <nyehia>
Bare Metal Hardware Provisioning sub component: baremetal-operator QA Contact: mlammon
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: abeekhof, beth.white, gharden, stbenjam
Version: 4.5   
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/metal3-io/baremetal-operator/pull/424
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Feature: Reboot API for baremetal machines Reason: Mainly required for machine remediation, though other use-cases might exist Result: Now a bare metal host can be rebooted by the new API
Story Points: ---
Clone Of:
: 1832245 (view as bug list) Environment:
Last Closed: 2020-07-13 17:35:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1832245, 1838430    

Description Nir 2020-05-05 11:17:13 UTC
Baremetal operator includes a new reboot api.
design doc: https://github.com/metal3-io/metal3-docs/pull/48
implementation PR: https://github.com/metal3-io/baremetal-operator/pull/424

We would like to backport this to 4.4 and we need a BZ for that.

This is required in order to have baremetal machine remediation feature, which reboots unhealthy hosts.

Comment 1 Stephen Benjamin 2020-05-06 11:45:17 UTC
It's the PR author's responsibility to backport. 

Please follow the OCP process.

- The component should be Bare Metal Hardware Provisioning / baremetal-operator, not ACM.
- You'll need a 4.5 BZ, verified by QE, attached to the 4.5 pull request
- You'll need to clone that BZ for 4.4.z, and open a PR to release-4.4 with the narrow set of changes


My guess is this is not easily backported. The original PR was a sync with upstream, https://github.com/openshift/baremetal-operator/pull/57 which involved a new go version and a move to go modules.

Comment 4 Nir 2020-05-20 06:31:47 UTC
What additional information is required here?
This is currently waiting for QE verification. Once QE verifies this bug we will continue with the backport as Stephen described.

Comment 5 Stephen Benjamin 2020-05-21 11:32:27 UTC
> This is currently waiting for QE verification. Once QE verifies this bug we will continue with the backport as Stephen described.

You can get a 4.4 PR open already. They'll need to verify the 4.5 bug to merge the 4.4 one, but it does not block opening a PR at all.

Comment 7 mlammon 2020-06-02 17:18:01 UTC
Successfully test on nightly build 4.5.0-0.nightly-2020-06-01-111748

Comment 9 errata-xmlrpc 2020-07-13 17:35:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409