Bug 1833465

Summary:	Revise use of helperv1.UpdateStatus() for updating operators status
Product:	OpenShift Container Platform	Reporter:	bpeterse
Component:	Management Console	Assignee:	Jakub Hadvig <jhadvig>
Status:	CLOSED ERRATA	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.5	CC:	aos-bugs, jokerman, yapei
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	The fix PR just update one function and remove useless code.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:36:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description bpeterse 2020-05-08 17:39:16 UTC

Description of problem:

We rushed to get a fix in to unblock the kube-1.18 rebase, resulting in this PR:
https://github.com/openshift/console-operator/pull/424

However, there are several items that need addressing to ensure that this code remains maintainable over time.  We need a fast follow with a few items:

- use library-go's SetDeploymentGeneration instead of reinventing it @ https://github.com/openshift/console-operator/pull/424#discussion_r422184416
- getDeploymentGeneration is now unused https://github.com/openshift/console-operator/pull/424#discussion_r422269547
- do not ignore errors when we flush status https://github.com/openshift/console-operator/pull/424#discussion_r421744310

Comment 1 bpeterse 2020-05-08 17:40:02 UTC

We will address it in a following sprint.

Comment 5 Yadan Pei 2020-05-19 09:44:43 UTC

After review the code changes, I think this bug can be verified 


The fix PR just update one function and remove useless code

Comment 6 errata-xmlrpc 2020-07-13 17:36:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409