Bug 1833465 - Revise use of helperv1.UpdateStatus() for updating operators status
Summary: Revise use of helperv1.UpdateStatus() for updating operators status
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.5.0
Assignee: Jakub Hadvig
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-08 17:39 UTC by bpeterse
Modified: 2020-07-13 17:36 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
The fix PR just update one function and remove useless code.
Clone Of:
Environment:
Last Closed: 2020-07-13 17:36:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console-operator pull 425 0 None closed Bug 1833465: Updating operator status - cleanUp 2020-06-24 02:14:17 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:36:34 UTC

Description bpeterse 2020-05-08 17:39:16 UTC
Description of problem:

We rushed to get a fix in to unblock the kube-1.18 rebase, resulting in this PR:
https://github.com/openshift/console-operator/pull/424

However, there are several items that need addressing to ensure that this code remains maintainable over time.  We need a fast follow with a few items:

- use library-go's SetDeploymentGeneration instead of reinventing it @ https://github.com/openshift/console-operator/pull/424#discussion_r422184416
- getDeploymentGeneration is now unused https://github.com/openshift/console-operator/pull/424#discussion_r422269547
- do not ignore errors when we flush status https://github.com/openshift/console-operator/pull/424#discussion_r421744310

Comment 1 bpeterse 2020-05-08 17:40:02 UTC
We will address it in a following sprint.

Comment 5 Yadan Pei 2020-05-19 09:44:43 UTC
After review the code changes, I think this bug can be verified 


The fix PR just update one function and remove useless code

Comment 6 errata-xmlrpc 2020-07-13 17:36:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.