Bug 1833879
Summary: | "Installation Guide" and "RHV Documents" didn't jump to the correct pages. | ||
---|---|---|---|
Product: | [oVirt] cockpit-ovirt | Reporter: | Wei Wang <weiwang> |
Component: | Hosted Engine | Assignee: | Gal Zaidman <gzaidman> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Wei Wang <weiwang> |
Severity: | medium | Docs Contact: | |
Priority: | urgent | ||
Version: | 0.14.6 | CC: | bugs, cshao, eslutsky, mavital, peyu, qiyuan, sbonazzo, shlei, weiwang, yaniwang, yturgema |
Target Milestone: | ovirt-4.4.1 | Flags: | sbonazzo:
ovirt-4.4?
sbonazzo: planning_ack? sbonazzo: devel_ack+ weiwang: testing_ack+ |
Target Release: | 0.14.7 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | cockpit-ovirt-0.14.7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-07-08 08:24:45 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Wei Wang
2020-05-11 06:18:28 UTC
Changed the links to beta for now since that is what we have, please open another bug with low priority on the D/S project for changing to 4.4 (In reply to Gal Zaidman from comment #1) > Changed the links to beta for now since that is what we have, please open > another bug with low priority on the D/S project for changing to 4.4 Open a d/s bug to trace it. https://bugzilla.redhat.com/show_bug.cgi?id=1835685 Test with ovirt-node-ng-4.4.0-0.20200608.0, bug is fixed. Move the status to "VERIFIED". This is a upstream bug, the links need to point to ovirt documentation, not RHV docs. Move the status to "ASSIGNED" (In reply to Wei Wang from comment #4) > This is a upstream bug, the links need to point to ovirt documentation, not > RHV docs. Move the status to "ASSIGNED" I need to understand just to not waste time on reproducing, did you tried installing the upstream project and use the links? Because looking at the code the upstream docs link didn't change (it shouldn't have) Just the downstream links has changed. (In reply to Gal Zaidman from comment #5) > (In reply to Wei Wang from comment #4) > > This is a upstream bug, the links need to point to ovirt documentation, not > > RHV docs. Move the status to "ASSIGNED" > > I need to understand just to not waste time on reproducing, did you tried > installing the upstream project and use the links? yes, I am sure I used the upstream project. > > Because looking at the code the upstream docs link didn't change (it > shouldn't have) Just the downstream links has changed. I have no idea why it show downstream links in upstream build. From the comment 3, that is the build I used for testing. Hi Wei Wang I check that you are very right! the links on the upstream project jump to the downstream doc. That was very strange to me since the links have never been changed upstream. So I Check and this is a packaging bug. Apparently this as always been the case! I see this on the first rpm package of ovirt which contained the links: cockpit-ovirt-dashboard-0.12.1-1.el7.noarch.rpm So this has always been the case on ovirt and no one noticed till now. This bug was on updating the links of 4.3 to 4.4, I suggest to close this bug with Verified because this is the case. and open a new bug on "cockpit ovirt(upstream) docs links point to downstream docs" The reason I don't want to handle it here is that we are planning a new project to replace cockpit ovirt in the upcoming versions. And since the fix may be a bit complicated and have side effects, I don't know if we want to spend the time on it currently. Some more technical details on the problem (mainly for the fixer of the bug): Cockpit ovirt configure file has a --with-rhev macro which configures the build for rhev. The first time that we run configure we run without that flag, but when we call configure from the .spec file the spec macro: %global use_rhev %( test -z @RHEV@ && echo 1 || echo 0) turn into %global use_rhev %( test -z && echo 1 || echo 0) which is true. I don't know if that bug dates back to the addition of the use_rhev macro (probably) but this will require us to evaluate the packaging scripts: - configure. - spec. - makefile. and understand what would be the repercussions of having this flag set only on downstream builds. I agree, let's handle in separate bug. Here let's verify we are pointing to 4.4 docs. Make scence, QE has verified this bug in comment 3. Move status to "VERIFIED". Report a new bug on "cockpit ovirt(upstream) docs links point to downstream docs" https://bugzilla.redhat.com/show_bug.cgi?id=1850439 This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |