Bug 1833879 - "Installation Guide" and "RHV Documents" didn't jump to the correct pages.
Summary: "Installation Guide" and "RHV Documents" didn't jump to the correct pages.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Hosted Engine
Version: 0.14.6
Hardware: Unspecified
OS: Unspecified
urgent
medium
Target Milestone: ovirt-4.4.1
: 0.14.7
Assignee: Gal Zaidman
QA Contact: Wei Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-11 06:18 UTC by Wei Wang
Modified: 2020-07-08 08:24 UTC (History)
11 users (show)

Fixed In Version: cockpit-ovirt-0.14.7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-08 08:24:45 UTC
oVirt Team: Integration
Embargoed:
sbonazzo: ovirt-4.4?
sbonazzo: planning_ack?
sbonazzo: devel_ack+
weiwang: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 109038 0 master MERGED Fix "Installation Guide" and "RHV Documents" links 2021-01-21 07:22:20 UTC

Description Wei Wang 2020-05-11 06:18:28 UTC
Description of problem:
After installing rhvh-4.4.0.18-0.20200507.0, clicking "Installation Guide" and "RHV Documents" in hosted engine deployment page, they didn't jump to the correct 4.4 (or 4.4-beta)pages. The 4.3 relative pages are jumped into.

Version-Release number of selected component (if applicable):
RHVH-4.4-20200507.1-RHVH-x86_64-dvd1.iso
cockpit-211.3-1.el8.x86_64
cockpit-ovirt-dashboard-0.14.6-1.el8ev.noarch
cockpit-system-211.3-1.el8.noarch
cockpit-ws-211.3-1.el8.x86_64
cockpit-dashboard-211.3-1.el8.noarch
subscription-manager-cockpit-1.26.17-1.el8_2.noarch
cockpit-storaged-211.3-1.el8.noarch
cockpit-bridge-211.3-1.el8.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Clean install RHVH-4.4-20200507.1-RHVH-x86_64-dvd1.iso
2. Click the two links "Installation Guide" and "RHV Documents" in hosted engine deployment page


Actual results:
They jump into 4.3 relative pages.

Expected results:
They jump into the correct 4.4 (or 4.4-beta)pages.

Additional info:

Comment 1 Gal Zaidman 2020-05-14 09:33:06 UTC
Changed the links to beta for now since that is what we have, please open another bug with low priority on the D/S project for changing to 4.4

Comment 2 Wei Wang 2020-05-14 10:22:43 UTC
(In reply to Gal Zaidman from comment #1)
> Changed the links to beta for now since that is what we have, please open
> another bug with low priority on the D/S project for changing to 4.4

Open a d/s bug to trace it. https://bugzilla.redhat.com/show_bug.cgi?id=1835685

Comment 3 Wei Wang 2020-06-09 06:24:34 UTC
Test with ovirt-node-ng-4.4.0-0.20200608.0, bug is fixed. Move the status to "VERIFIED".

Comment 4 Wei Wang 2020-06-09 07:54:49 UTC
This is a upstream bug, the links need to point to ovirt documentation, not RHV docs. Move the status to "ASSIGNED"

Comment 5 Gal Zaidman 2020-06-23 08:17:36 UTC
(In reply to Wei Wang from comment #4)
> This is a upstream bug, the links need to point to ovirt documentation, not
> RHV docs. Move the status to "ASSIGNED"

I need to understand just to not waste time on reproducing, did you tried installing the upstream project and use the links?

Because looking at the code the upstream docs link didn't change (it shouldn't have) Just the downstream links has changed.

Comment 6 Wei Wang 2020-06-23 09:43:00 UTC
(In reply to Gal Zaidman from comment #5)
> (In reply to Wei Wang from comment #4)
> > This is a upstream bug, the links need to point to ovirt documentation, not
> > RHV docs. Move the status to "ASSIGNED"
> 
> I need to understand just to not waste time on reproducing, did you tried
> installing the upstream project and use the links?
yes, I am sure I used the upstream project.
> 
> Because looking at the code the upstream docs link didn't change (it
> shouldn't have) Just the downstream links has changed.
I have no idea why it show downstream links in upstream build.

Comment 7 Wei Wang 2020-06-23 09:44:06 UTC
From the comment 3, that is the build I used for testing.

Comment 8 Gal Zaidman 2020-06-24 06:54:34 UTC
Hi Wei Wang
I check that you are very right! the links on the upstream project jump to the downstream doc.
That was very strange to me since the links have never been changed upstream.
So I Check and this is a packaging bug.
Apparently this as always been the case! I see this on the first rpm package of ovirt which contained the links:

cockpit-ovirt-dashboard-0.12.1-1.el7.noarch.rpm

So this has always been the case on ovirt and no one noticed till now.

This bug was on updating the links of 4.3 to 4.4, I suggest to close this bug with Verified because this is the case.
and open a new bug on "cockpit ovirt(upstream) docs links point to downstream docs"
The reason I don't want to handle it here is that we are planning a new project to replace cockpit ovirt in the upcoming versions.
And since the fix may be a bit complicated and have side effects, I don't know if we want to spend the time on it currently.

Some more technical details on the problem (mainly for the fixer of the bug):

Cockpit ovirt configure file has a --with-rhev macro which configures the build for rhev.
The first time that we run configure we run without that flag, but when we call configure from the .spec file the spec macro:
%global use_rhev %( test -z @RHEV@ && echo 1 || echo 0)
turn into
%global use_rhev %( test -z  && echo 1 || echo 0)
which is true.

I don't know if that bug dates back to the addition of the use_rhev macro (probably) but this will require us to evaluate the packaging scripts:
- configure.
- spec.
- makefile.

and understand what would be the repercussions of having this flag set only on downstream builds.

Comment 9 Sandro Bonazzola 2020-06-24 06:59:32 UTC
I agree, let's handle in separate bug. Here let's verify we are pointing to 4.4 docs.

Comment 10 Wei Wang 2020-06-24 10:20:54 UTC
Make scence, QE has verified this bug in comment 3. Move status to "VERIFIED".
Report a new bug on "cockpit ovirt(upstream) docs links point to downstream docs"
https://bugzilla.redhat.com/show_bug.cgi?id=1850439

Comment 11 Sandro Bonazzola 2020-07-08 08:24:45 UTC
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.