Bug 1834163
| Summary: | Error "Missing fields in node labels" shows on new affinity pages immediately | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Guohua Ouyang <gouyang> |
| Component: | Console Kubevirt Plugin | Assignee: | Yaacov Zamir <yzamir> |
| Status: | CLOSED ERRATA | QA Contact: | Nelly Credi <ncredi> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.5 | CC: | aos-bugs, gouyang, yzamir |
| Target Milestone: | --- | ||
| Target Release: | 4.5.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-13 17:36:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Guohua Ouyang
2020-05-11 08:35:27 UTC
It still shows the warning, maybe it should only shows the warning by click "Save Affinity rule" if something is missing. Changing back to ON_QA because we need to see this warnings while users interact with the form.
> It still shows the warning, maybe it should only shows the warning by click "Save Affinity rule" if something is missing.
It is suppose to show the warning immediately when the user enter a new affinity rule,
we can not want to wait for "save" because it will be saved and user will not see warning, this warnings do not ( and should not ) block you from saving
they are there to help users make good decisions about what rules to write.
Then I think it's a bad design here, a highlight warning on a fresh opened page causes panic. By removing the key/value box for "Add Expression" can make the warning gone, is it good to do it? Thanks, fixed the wrong message.
Moving back to assigned
> By removing the key/value box for "Add Expression" can make the warning gone, is it good to do it?
sounds good to me, this it the approach we use in the other modals.
verified on upstream 4.5 branch, commit 88b7689b0fb3dfc557d9e06dc509952b9233661e. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |