Bug 1834207

python-cheroot fails to build with Python 3.9.0a6.


==================================== ERRORS ====================================
_____________ ERROR at setup of test_peercreds_unix_sock[abstract] _____________

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d44739890>
unix_sock_file = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'

    @pytest.fixture
    def peercreds_enabled_server_and_client(http_server, unix_sock_file):
        """Construct a test server with `peercreds_enabled`."""
        httpserver = http_server.send(unix_sock_file)
        httpserver.gateway = _TestGateway
        httpserver.peercreds_enabled = True
>       return httpserver, get_server_client(httpserver)

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d44739890>
httpserver = <cheroot.server.HTTPServer object at 0x7f7d44624e50>
unix_sock_file = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'

cheroot/test/test_server.py:175: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
cheroot/testing.py:153: in get_server_client
    return _TestClient(server)
cheroot/testing.py:84: in __init__
    self._http_connection = self.get_connection()
cheroot/testing.py:96: in get_connection
    return conn_cls(name)
/usr/lib64/python3.9/http/client.py:831: in __init__
    self._validate_host(self.host)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <http.client.HTTPConnection object at 0x7f7d447aa1f0>
host = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'

    def _validate_host(self, host):
        """Validate a host so it doesn't contain control characters."""
        # Prevent CVE-2019-18348.
        match = _contains_disallowed_url_pchar_re.search(host)
        if match:
>           raise InvalidURL(f"URL can't contain control characters. {host!r} "
                             f"(found at least {match.group()!r})")
E           http.client.InvalidURL: URL can't contain control characters. '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a' (found at least '\x00')

host       = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'
match      = <re.Match object; span=(0, 1), match='\x00'>
self       = <http.client.HTTPConnection object at 0x7f7d447aa1f0>

/usr/lib64/python3.9/http/client.py:1193: InvalidURL
_______ ERROR at setup of test_peercreds_unix_sock_with_lookup[abstract] _______

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d446322e0>
unix_sock_file = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'

    @pytest.fixture
    def peercreds_enabled_server_and_client(http_server, unix_sock_file):
        """Construct a test server with `peercreds_enabled`."""
        httpserver = http_server.send(unix_sock_file)
        httpserver.gateway = _TestGateway
        httpserver.peercreds_enabled = True
>       return httpserver, get_server_client(httpserver)

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d446322e0>
httpserver = <cheroot.server.HTTPServer object at 0x7f7d44fdca30>
unix_sock_file = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'

cheroot/test/test_server.py:175: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
cheroot/testing.py:153: in get_server_client
    return _TestClient(server)
cheroot/testing.py:84: in __init__
    self._http_connection = self.get_connection()
cheroot/testing.py:96: in get_connection
    return conn_cls(name)
/usr/lib64/python3.9/http/client.py:831: in __init__
    self._validate_host(self.host)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <http.client.HTTPConnection object at 0x7f7d446572e0>
host = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'

    def _validate_host(self, host):
        """Validate a host so it doesn't contain control characters."""
        # Prevent CVE-2019-18348.
        match = _contains_disallowed_url_pchar_re.search(host)
        if match:
>           raise InvalidURL(f"URL can't contain control characters. {host!r} "
                             f"(found at least {match.group()!r})")
E           http.client.InvalidURL: URL can't contain control characters. '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717' (found at least '\x00')

host       = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'
match      = <re.Match object; span=(0, 1), match='\x00'>
self       = <http.client.HTTPConnection object at 0x7f7d446572e0>

/usr/lib64/python3.9/http/client.py:1193: InvalidURL
- generated xml file: /builddir/build/BUILD/cheroot-8.2.1/junit-test-results.xml -

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01377128-python-cheroot/

For all our attempts to build python-cheroot with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-cheroot/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.