Bug 1834207 - python-cheroot fails to build with Python 3.9: InvalidURL
Summary: python-cheroot fails to build with Python 3.9: InvalidURL
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-cheroot
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Dan Radez
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1841687 (view as bug list)
Depends On:
Blocks: PYTHON39 F33FTBFS F33FailsToInstall 1841688
TreeView+ depends on / blocked
 
Reported: 2020-05-11 10:23 UTC by Miro Hrončok
Modified: 2020-06-03 09:28 UTC (History)
8 users (show)

Fixed In Version: python-cheroot-8.2.1-3.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-03 09:28:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-05-11 10:23:09 UTC
python-cheroot fails to build with Python 3.9.0a6.


==================================== ERRORS ====================================
_____________ ERROR at setup of test_peercreds_unix_sock[abstract] _____________

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d44739890>
unix_sock_file = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'

    @pytest.fixture
    def peercreds_enabled_server_and_client(http_server, unix_sock_file):
        """Construct a test server with `peercreds_enabled`."""
        httpserver = http_server.send(unix_sock_file)
        httpserver.gateway = _TestGateway
        httpserver.peercreds_enabled = True
>       return httpserver, get_server_client(httpserver)

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d44739890>
httpserver = <cheroot.server.HTTPServer object at 0x7f7d44624e50>
unix_sock_file = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'

cheroot/test/test_server.py:175: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
cheroot/testing.py:153: in get_server_client
    return _TestClient(server)
cheroot/testing.py:84: in __init__
    self._http_connection = self.get_connection()
cheroot/testing.py:96: in get_connection
    return conn_cls(name)
/usr/lib64/python3.9/http/client.py:831: in __init__
    self._validate_host(self.host)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <http.client.HTTPConnection object at 0x7f7d447aa1f0>
host = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'

    def _validate_host(self, host):
        """Validate a host so it doesn't contain control characters."""
        # Prevent CVE-2019-18348.
        match = _contains_disallowed_url_pchar_re.search(host)
        if match:
>           raise InvalidURL(f"URL can't contain control characters. {host!r} "
                             f"(found at least {match.group()!r})")
E           http.client.InvalidURL: URL can't contain control characters. '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a' (found at least '\x00')

host       = '\x00cheroot-test-socket45f2762e-8f37-4854-902a-7ed8831e847a'
match      = <re.Match object; span=(0, 1), match='\x00'>
self       = <http.client.HTTPConnection object at 0x7f7d447aa1f0>

/usr/lib64/python3.9/http/client.py:1193: InvalidURL
_______ ERROR at setup of test_peercreds_unix_sock_with_lookup[abstract] _______

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d446322e0>
unix_sock_file = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'

    @pytest.fixture
    def peercreds_enabled_server_and_client(http_server, unix_sock_file):
        """Construct a test server with `peercreds_enabled`."""
        httpserver = http_server.send(unix_sock_file)
        httpserver.gateway = _TestGateway
        httpserver.peercreds_enabled = True
>       return httpserver, get_server_client(httpserver)

http_server = <generator object http_server.<locals>.start_srv at 0x7f7d446322e0>
httpserver = <cheroot.server.HTTPServer object at 0x7f7d44fdca30>
unix_sock_file = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'

cheroot/test/test_server.py:175: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
cheroot/testing.py:153: in get_server_client
    return _TestClient(server)
cheroot/testing.py:84: in __init__
    self._http_connection = self.get_connection()
cheroot/testing.py:96: in get_connection
    return conn_cls(name)
/usr/lib64/python3.9/http/client.py:831: in __init__
    self._validate_host(self.host)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <http.client.HTTPConnection object at 0x7f7d446572e0>
host = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'

    def _validate_host(self, host):
        """Validate a host so it doesn't contain control characters."""
        # Prevent CVE-2019-18348.
        match = _contains_disallowed_url_pchar_re.search(host)
        if match:
>           raise InvalidURL(f"URL can't contain control characters. {host!r} "
                             f"(found at least {match.group()!r})")
E           http.client.InvalidURL: URL can't contain control characters. '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717' (found at least '\x00')

host       = '\x00cheroot-test-socketd9e73390-3c13-44c0-b721-4848c86ff717'
match      = <re.Match object; span=(0, 1), match='\x00'>
self       = <http.client.HTTPConnection object at 0x7f7d446572e0>

/usr/lib64/python3.9/http/client.py:1193: InvalidURL
- generated xml file: /builddir/build/BUILD/cheroot-8.2.1/junit-test-results.xml -

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01377128-python-cheroot/

For all our attempts to build python-cheroot with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-cheroot/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-05-25 13:02:32 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 2 Miro Hrončok 2020-05-26 10:32:00 UTC
Quite a lot of things need this:

$ repoquery --repo=rawhide{,-source} --whatrequires python3-cheroot --recursive
ceph-2:15.2.2-1.fc33.x86_64
ceph-mgr-2:15.2.2-1.fc33.x86_64
ceph-mgr-cephadm-2:15.2.2-1.fc33.noarch
ceph-mgr-dashboard-2:15.2.2-1.fc33.noarch
ceph-mgr-diskprediction-cloud-2:15.2.2-1.fc33.noarch
ceph-mgr-diskprediction-local-2:15.2.2-1.fc33.noarch
ceph-mgr-k8sevents-2:15.2.2-1.fc33.noarch
ceph-mgr-modules-core-2:15.2.2-1.fc33.noarch
ceph-mgr-rook-2:15.2.2-1.fc33.noarch
imagefactory-0:1.1.15-2.fc33.noarch
imagefactory-plugins-0:1.1.15-5.fc33.noarch
imagefactory-plugins-IndirectionCloud-0:1.1.15-5.fc33.noarch
imagefactory-plugins-OVA-0:1.1.15-5.fc33.noarch
imagefactory-plugins-RHEVM-0:1.1.15-5.fc33.noarch
imagefactory-plugins-TinMan-0:1.1.15-5.fc33.noarch
imagefactory-plugins-ovfcommon-0:1.1.15-5.fc33.noarch
imagefactory-plugins-vSphere-0:1.1.15-5.fc33.noarch
ipsilon-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-authfas-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-authform-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-authgssapi-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-authldap-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-authpam-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-base-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-infofas-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-infosssd-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-openid-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-openidc-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-persona-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-saml2-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-theme-Fedora-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-theme-openSUSE-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
ipsilon-tools-ipa-0:2.1.0-12.git20200428.f99a7d4.fc33.noarch
lokalize-0:19.12.3-1.fc33.x86_64
mnemosyne-0:2.6.1-5.fc33.noarch
mnemosyne-0:2.6.1-5.fc33.src
python-CacheControl-0:0.12.6-2.fc32.src
python-cherrypy-0:18.4.0-2.fc32.src
python-webpy-0:0.50-2.fc33.src
python-ws4py-0:0.5.1-2.fc33.src
python3-cherrypy-0:18.4.0-2.fc32.noarch
python3-paste-script-0:3.2.0-2.fc32.noarch
python3-webpy-0:0.50-2.fc33.noarch
python3-ws4py-0:0.5.1-2.fc33.noarch
salt-api-0:3000.3-1.fc33.noarch
translate-toolkit-0:2.5.1-1.fc33.noarch
translate-toolkit-docs-0:2.5.1-1.fc33.noarch
xca-0:2.2.1-1.fc32.src

Comment 3 Fabien Boucher 2020-05-26 13:04:46 UTC
Hi, I see Dan opended a Review request here: https://bugzilla.redhat.com/show_bug.cgi?id=1833379
Looks like to be a requirement to the bump of cheroot to 8.3.0.

Comment 4 Miro Hrončok 2020-05-29 07:12:14 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 5 Miro Hrončok 2020-06-01 11:31:23 UTC
*** Bug 1841687 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.