Bug 1834254

Summary: EventSourceIcon's are dependent apiGroup and version, should depend on Kind
Product: OpenShift Container Platform Reporter: Jaivardhan Kumar <jakumar>
Component: Dev ConsoleAssignee: Jaivardhan Kumar <jakumar>
Status: CLOSED ERRATA QA Contact: Gajanan More <gamore>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.5CC: aos-bugs, nmukherj
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:37:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
topology page
none
add page none

Description Jaivardhan Kumar 2020-05-11 12:02:58 UTC
Description:
EventSourceIcon's are dependent apiGroup and version, should depend on Kind as we are supporting dynamic Sources now so reference may change.

Currently we detect based on `referenceForModel` wrt to model in codebase, we should rely on Kind as for builtin Sources as well ApiVersion/group may change in future (as we are fetching it from CRDs based on duck type label) but kind would be same.

Update pingSource to use same icon as CronJob

Prerequisites (if any, like setup, operators/versions): Install Serverless/Eventing

Steps to Reproduce:
1. Go to DevConsole -> Add -> EventSources
2. Check EventSource Icons
3. Create an EventSource from built'in and check icon in topology

Actual results: Should show proper icons for each sources and default icon shown for pingSource

Expected results: Should show proper icons for each sources and ping source should show an icon

Comment 3 Gajanan More 2020-05-14 11:58:37 UTC
Created attachment 1688406 [details]
topology page

Comment 4 Gajanan More 2020-05-14 11:58:46 UTC
Created attachment 1688407 [details]
add page

Comment 5 Gajanan More 2020-05-14 11:59:08 UTC
I have validated the bugzilla on
Build: 4.5.0-0.ci-2020-05-13-231257
Browser: Google Chrome Version 81.0.4044.129
Please have a look at the shared screenshots
Marking this as verified.

Comment 6 errata-xmlrpc 2020-07-13 17:37:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409