Bug 1835851
| Summary: | Test DeleteNodeTwice is broken | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Joel Speed <jspeed> |
| Component: | Cloud Compute | Assignee: | Joel Speed <jspeed> |
| Cloud Compute sub component: | Other Providers | QA Contact: | sunzhaohua <zhsun> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | high | ||
| Priority: | high | ||
| Version: | 4.5 | ||
| Target Milestone: | --- | ||
| Target Release: | 4.5.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: The test case was relying on broken behaviour or our interface which was then fixed. The test did not actually cover the code it was supposed to.
Consequence: The tests no longer passed.
Fix: Rewrite the test not to use our interface and to rely on core Kubernetes code rather than the code we are testing.
Result: Test now passes. Test fails if removing the part of the code it was meant to cover.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-13 17:38:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Joel Speed
2020-05-14 15:41:14 UTC
@Joel Speed Could you give me some guidance how to test this locally? @Sunzhaohua I'm not entirely sure how much testing you can do of this change since it was just a fix to a test. The test was meant to cover https://github.com/openshift/kubernetes-autoscaler/blob/9ac8ed2c05132e66580ec7d39d2118ae17b01298/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_nodegroup.go#L154-L157, but if those lines were removed, the tests still passed, that is until https://github.com/openshift/kubernetes-autoscaler/pull/147 merged which highlighted that the test itself was broken. You should be able to verify that the test fails if you remove the content of the first link that I sent, showing that the nodes get deleted twice and the MachineSet will have 4 replicas instead of the 7 expected Move it to Verified since it is a fix to test. No effect on function. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |