Bug 1835851 - Test DeleteNodeTwice is broken
Summary: Test DeleteNodeTwice is broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.5
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.5.0
Assignee: Joel Speed
QA Contact: sunzhaohua
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-14 15:41 UTC by Joel Speed
Modified: 2020-07-13 17:39 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: The test case was relying on broken behaviour or our interface which was then fixed. The test did not actually cover the code it was supposed to. Consequence: The tests no longer passed. Fix: Rewrite the test not to use our interface and to rely on core Kubernetes code rather than the code we are testing. Result: Test now passes. Test fails if removing the part of the code it was meant to cover.
Clone Of:
Environment:
Last Closed: 2020-07-13 17:38:54 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift kubernetes-autoscaler pull 151 0 None closed Bug 1835851: Update DeleteNodesTwice test 2020-06-24 02:38:51 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:39:10 UTC

Description Joel Speed 2020-05-14 15:41:14 UTC
Description of problem:

This test is currently broken and fails on each PR. It is blocking anything from being merged into the kubernetes-autoscaler repository which could become an issue if we have bugs reported

Comment 3 sunzhaohua 2020-06-01 01:04:22 UTC
@Joel Speed Could you give me some guidance how to test this locally?

Comment 4 Joel Speed 2020-06-01 09:49:22 UTC
@Sunzhaohua I'm not entirely sure how much testing you can do of this change since it was just a fix to a test. The test was meant to cover https://github.com/openshift/kubernetes-autoscaler/blob/9ac8ed2c05132e66580ec7d39d2118ae17b01298/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_nodegroup.go#L154-L157, but if those lines were removed, the tests still passed, that is until https://github.com/openshift/kubernetes-autoscaler/pull/147 merged which highlighted that the test itself was broken. You should be able to verify that the test fails if you remove the content of the first link that I sent, showing that the nodes get deleted twice and the MachineSet will have 4 replicas instead of the 7 expected

Comment 5 sunzhaohua 2020-06-02 01:22:35 UTC
Move it to Verified since it is a fix to test. No effect on function.

Comment 6 errata-xmlrpc 2020-07-13 17:38:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.