Bug 1837241

Summary:	OCP4.4.z backport - Issue with memoryMB validation
Product:	OpenShift Container Platform	Reporter:	Jan Zmeskal <jzmeskal>
Component:	Installer	Assignee:	Roy Golan <rgolan>
Installer sub component:	OpenShift on RHV	QA Contact:	Lucie Leistnerova <lleistne>
Status:	CLOSED WONTFIX	Docs Contact:
Severity:	low
Priority:	medium	CC:	hpopal, lleistne, pelauter, rciatti, sbonazzo
Version:	4.4
Target Milestone:	---
Target Release:	4.4.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1837239	Environment:
Last Closed:	2020-08-03 15:09:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1837239
Bug Blocks:

Description Jan Zmeskal 2020-05-19 07:20:21 UTC

+++ This bug was initially created as a clone of Bug #1837239 +++

Description of problem:
Some validations for OpenShift on RHV nodes don't seem to be working as expected. Namely they are:
- memory of VM
- VM type

For more info, see here: https://bugzilla.redhat.com/show_bug.cgi?id=1820300#c9

Version-Release number of the following components:
openshift-install-linux-4.5.0-0.nightly-2020-05-18-043243

How reproducible:
100 %

Steps to Reproduce:
1. openshift install create install-config
2. Set value of VM's memory to 0
3. Set VM type to an arbitrary string that's neither "desktop", "server" or "high_performance"

Actual results:
Installer accepts both of these customization

Expected results:
Installer should fail early with a helpful error message

Comment 1 Jan Zmeskal 2020-05-20 12:58:19 UTC

Update: I found out that the VM type attribute works as expected. So the only verification required here is to check that memoryMB attribute does not take value of zero or lower.

Comment 4 Sandro Bonazzola 2020-06-18 06:51:29 UTC

due to capacity constraints we will be revisiting this bug in the upcoming sprint

Comment 6 Jan Zmeskal 2020-08-03 15:09:10 UTC

Closing as 4.4.z is approaching end of life cycle and this issue is not so important to require backport in the first place.

Comment 7 Red Hat Bugzilla 2023-09-14 06:00:29 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days