This bug was initially created as a copy of Bug #1813741
I am copying this bug because:
Description of problem:
The masters/workers instance parametes should be customized using the machine pool. Today all of the parameters are set on the initial template creation, and can only be overriden by export TF_VAR_xyz, which is a bad way of exposing this capability.
oVirt's machinepool object should have mem/cpu/disk size parameters, and they
should be used to create the instances, if they are set.
With the change made in Bug 1813741 I'm adding the following machine config properties:
- instance type id
- vm type
- os disk size
This is an urgent issue, we need to use install-config, not TF env variables per OCP arch.
The repo has now a customization.md do document how to customize the platform.
Jan you can start the verification by using this document or just follow the steps bellow.
Lets fully customize the masters and workers by using this in the install-config:
- name: worker
* instanceTypeID can also be set, but can't be mixed with cpu or memoryMB.
Try setting instanceTypeID: 0000000b-000b-000b-000b-00000000021f which is the XLarge instance type with 16G mem and 4 cores
- control place disks and workers are extended beyond 16GB by request
- cpu cores and socket can be customized
More behaviour added is validation - the ovirt-specifics in install-config will make sure that:
cpu.cores > 0
cpu.sockets > 0
mem > 0
not mixing instanceTypeID and mem or cpu
instantceTypeID is valid UUID
vmType is on of "server", "dekstop", "high_performance"
osDisk.diskGB > 0
Okay, so I tested few scenarios around this, for complete breakdown see the link in comment 8. As far as I can tell, the actual customizations do work, but I found some issues with validations.
1. Installer allows for memoryMB with value 0
2. Installer allows for arbitrary string provided to vmType
3. When specifying disk size < 16GB, disk of 16GB is created
Point 3 isn't a big issue as long as it's documented, however points 1 and 2 are in my opinion validations not working as expected.
Since this bug is rather urgent, I'm moving to VERIFIED since the basic functionality works fine. The issues with validation are being tracked here: https://bugzilla.redhat.com/show_bug.cgi?id=1837239
*** Bug 1818577 has been marked as a duplicate of this bug. ***
*** Bug 1821215 has been marked as a duplicate of this bug. ***
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.