Bug 1839148
| Summary: | Review Request: mingw-protobuf - MinGW Windows protobuf library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sandro Mani <manisandro> |
| Component: | Package Review | Assignee: | Richard Shaw <hobbes1069> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hobbes1069, package-review |
| Target Milestone: | --- | Flags: | hobbes1069:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-22 18:33:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sandro Mani
2020-05-22 14:57:00 UTC
Ok, I'll preface this by saying I'm not an expert MinGW reviewer. I went ahead and ran fedora-review on the package even though a lot of it doesn't apply to MinGW packages.
Requires
--------
mingw32-protobuf-static (rpmlib, GLIBC filtered):
mingw32-protobuf
mingw64-protobuf-static (rpmlib, GLIBC filtered):
mingw64-protobuf
Should these require the main library? Being static they don't have any real dependency on them...
The example spec file shows this but I don't see any hard requirement.
https://fedoraproject.org/wiki/Packaging:MinGW#Compilation_of_binaries
Not a show stopper.
***APPROVED***
Thanks! - The dependency on the main package is just to ensure you also get headers/pkgconfig files/license etc when installing the -static subpackage. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-protobuf |