Bug 1839148 - Review Request: mingw-protobuf - MinGW Windows protobuf library
Summary: Review Request: mingw-protobuf - MinGW Windows protobuf library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard Shaw
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-22 14:57 UTC by Sandro Mani
Modified: 2020-05-22 18:33 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-22 18:33:17 UTC
Type: ---
Embargoed:
hobbes1069: fedora-review+


Attachments (Terms of Use)

Description Sandro Mani 2020-05-22 14:57:00 UTC
Spec URL: https://smani.fedorapeople.org/review/mingw-protobuf.spec
SRPM URL: https://smani.fedorapeople.org/review/mingw-protobuf-3.11.4-1.fc33.src.rpm
Description: MinGW Windows protobuf library
Fedora Account System Username: smani

Comment 1 Richard Shaw 2020-05-22 17:33:26 UTC
Ok, I'll preface this by saying I'm not an expert MinGW reviewer. I went ahead and ran fedora-review on the package even though a lot of it doesn't apply to MinGW packages.

Requires
--------
mingw32-protobuf-static (rpmlib, GLIBC filtered):
    mingw32-protobuf

mingw64-protobuf-static (rpmlib, GLIBC filtered):
    mingw64-protobuf

Should these require the main library? Being static they don't have any real dependency on them...

The example spec file shows this but I don't see any hard requirement.

https://fedoraproject.org/wiki/Packaging:MinGW#Compilation_of_binaries

Not a show stopper.

***APPROVED***

Comment 2 Sandro Mani 2020-05-22 17:41:47 UTC
Thanks! - The dependency on the main package is just to ensure you also get headers/pkgconfig files/license etc when installing the -static subpackage.

Comment 3 Gwyn Ciesla 2020-05-22 18:05:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-protobuf


Note You need to log in before you can comment on or make changes to this bug.