Bug 1839376

Summary:	Review Request: rust-log-panics - Panic hook which logs panic messages rather than printing them
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	igor.raits, package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-22 01:21:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michel Lind 2020-05-23 19:54:27 UTC

Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-log-panics.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-log-panics-2.0.0-1.fc32.src.rpm
Description: Panic hook which logs panic messages rather than printing them.
Fedora Account System Username: salimma

Comment 1 Igor Raits 2020-05-23 21:17:40 UTC

> # tests require an older version of env_logger
can you also put link to upstream that requests update of this dependency? Also from my experience, bumping env_logger is just about bumping version in toml without any other change.

> # Initial patched metadata
Please also put some comment what is being patched there so that it is not necessary to open a patch.

Comment 2 Robert-André Mauchin 🐧 2020-06-25 19:19:51 UTC

Try to backport: https://github.com/sfackler/rust-log-panics/commit/4dcf408a6ff2e458abbb62702ecab088c38596c6

===============================================================================
diff -up log-panics-2.0.0/examples/panic.rs.orig log-panics-2.0.0/examples/panic.rs
--- log-panics-2.0.0/examples/panic.rs.orig	2017-08-05 07:32:20.000000000 +0200
+++ log-panics-2.0.0/examples/panic.rs	2020-06-25 21:09:26.785895461 +0200
@@ -2,7 +2,7 @@ extern crate log_panics;
 extern crate env_logger;
 
 fn main() {
-    env_logger::init().unwrap();
+    env_logger::init();
     log_panics::init();
 
     foo();

===============================================================================

  And bump env_logger to 0.7



 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines


Please add this patch and address Igor's comments.

Comment 3 Michel Lind 2020-06-26 18:30:05 UTC

ack, will work on it this weekend. Thanks for the feedback!

Comment 4 Michel Lind 2020-06-28 17:01:30 UTC

Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-log-panics.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-log-panics-2.0.0-2.fc32.src.rpm

upstream PR (linked in updated spec): https://github.com/sfackler/rust-log-panics/pull/6

Comment 5 Robert-André Mauchin 🐧 2020-06-29 14:35:12 UTC

Package approved.

Comment 6 Michel Lind 2020-06-30 01:07:10 UTC

Thanks!

❯ fedpkg request-repo rust-log-panics 1839376            
https://pagure.io/releng/fedora-scm-requests/issue/26664

Comment 7 Gwyn Ciesla 2020-06-30 15:20:05 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-log-panics