Bug 1839376 - Review Request: rust-log-panics - Panic hook which logs panic messages rather than printing them
Summary: Review Request: rust-log-panics - Panic hook which logs panic messages rather...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-23 19:54 UTC by Michel Lind
Modified: 2020-07-22 01:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-22 01:21:03 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2020-05-23 19:54:27 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-log-panics.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-log-panics-2.0.0-1.fc32.src.rpm
Description: Panic hook which logs panic messages rather than printing them.
Fedora Account System Username: salimma

Comment 1 Igor Raits 2020-05-23 21:17:40 UTC
> # tests require an older version of env_logger
can you also put link to upstream that requests update of this dependency? Also from my experience, bumping env_logger is just about bumping version in toml without any other change.

> # Initial patched metadata
Please also put some comment what is being patched there so that it is not necessary to open a patch.

Comment 2 Robert-André Mauchin 🐧 2020-06-25 19:19:51 UTC
Try to backport: https://github.com/sfackler/rust-log-panics/commit/4dcf408a6ff2e458abbb62702ecab088c38596c6

===============================================================================
diff -up log-panics-2.0.0/examples/panic.rs.orig log-panics-2.0.0/examples/panic.rs
--- log-panics-2.0.0/examples/panic.rs.orig	2017-08-05 07:32:20.000000000 +0200
+++ log-panics-2.0.0/examples/panic.rs	2020-06-25 21:09:26.785895461 +0200
@@ -2,7 +2,7 @@ extern crate log_panics;
 extern crate env_logger;
 
 fn main() {
-    env_logger::init().unwrap();
+    env_logger::init();
     log_panics::init();
 
     foo();

===============================================================================

  And bump env_logger to 0.7



 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines


Please add this patch and address Igor's comments.

Comment 3 Michel Lind 2020-06-26 18:30:05 UTC
ack, will work on it this weekend. Thanks for the feedback!

Comment 5 Robert-André Mauchin 🐧 2020-06-29 14:35:12 UTC
Package approved.

Comment 6 Michel Lind 2020-06-30 01:07:10 UTC
Thanks!

❯ fedpkg request-repo rust-log-panics 1839376            
https://pagure.io/releng/fedora-scm-requests/issue/26664

Comment 7 Gwyn Ciesla 2020-06-30 15:20:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-log-panics


Note You need to log in before you can comment on or make changes to this bug.