Bug 1840159

Summary: Limit Option not performed for Splitstack Scaleup
Product: Red Hat OpenStack Reporter: David Rosenfeld <drosenfe>
Component: openstack-tripleo-commonAssignee: Luke Short <lshort>
Status: CLOSED ERRATA QA Contact: David Rosenfeld <drosenfe>
Severity: urgent Docs Contact:
Priority: high    
Version: 16.1 (Train)CC: aschultz, emacchi, lshort, mburns, sclewis, slinaber
Target Milestone: rcKeywords: Triaged, ZStream
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-common-11.3.3-0.20200527133429.f601068.el8ost Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-29 07:52:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1767581    

Description David Rosenfeld 2020-05-26 13:41:49 UTC 
Description of problem: Performed Scale Up with --limit option on a splitstack deployment. Test completed successfully, but when looking at logs deployment was not limited to the node specified by the limit command. 


Version-Release number of selected component (if applicable): RHOS-16.1-RHEL-8-20200520.n.0


How reproducible: Every time.


Steps to Reproduce:
1. In a Splitstack deployment perform a scale with limit option e.g.:

openstack overcloud deploy \
--limit compute-2 --skip-tags external_deploy_steps --tags all \

2. After deployment check deployment command in file /var/lib/mistral/overcloud/ansible-playbook-command.sh for limit option (it wasn't included):

ansible-playbook-3 -v
/var/lib/mistral/overcloud/deploy_steps_playbook.yaml --become --timeout 600 --inventory-file
/var/lib/mistral/overcloud/tripleo-ansible-inventory.yaml --tags all --skip-tags opendev-validation,external_deploy_steps "$@"

3. Check scale up log and verify that deployment was limited to compute-2 (it wasn't)

tail -20l overcloud_scale_up.log
ceph-1                     : ok=262  changed=109  unreachable=0    failed=0    skipped=123  rescued=0    ignored=0   
ceph-2                     : ok=262  changed=109  unreachable=0    failed=0    skipped=123  rescued=0    ignored=0   
compute-0                  : ok=286  changed=127  unreachable=0    failed=0    skipped=122  rescued=0    ignored=0   
compute-1                  : ok=285  changed=127  unreachable=0    failed=0    skipped=122  rescued=0    ignored=0   
compute-2                  : ok=292  changed=169  unreachable=0    failed=0    skipped=119  rescued=0    ignored=0   
controller-0               : ok=335  changed=158  unreachable=0    failed=0    skipped=137  rescued=0    ignored=0   
controller-1               : ok=318  changed=158  unreachable=0    failed=0    skipped=139  rescued=0    ignored=0   
controller-2               : ok=318  changed=158  unreachable=0    failed=0    skipped=139  rescued=0    ignored=0   
undercloud                 : ok=5    changed=2    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

Friday 22 May 2020  19:42:24 -0400 (0:00:00.766)       0:28:04.036 ************ 
=============================================================================== 
Waiting for messages on queue 'tripleo' with no timeout.

Ansible passed.
Overcloud configuration completed.
Overcloud Endpoint: http://10.0.0.141:5000
Overcloud Horizon Dashboard URL: http://10.0.0.141:80/dashboard
Overcloud rc file: /home/stack/overcloudrc
Overcloud Deployed
[stack@undercloud-0 ~]$

Actual results: Deployment performed on all servers in node during scale up


Expected results: Deployment is limited to just the node include in limit command (e.g. compute-2)


Additional info:
Comment 7 David Rosenfeld 2020-06-09 12:46:08 UTC 
Same splitstack Jenkins job was run.

The deployment command in /var/lib/mistral/overcloud/ansible-playbook-command.sh now contains the limit option:

ansible-playbook-3 -v /var/lib/mistral/overcloud/deploy_steps_playbook.yaml --limit compute-2 --become --timeout 600 --inventory-file /var/lib/mistr
al/overcloud/tripleo-ansible-inventory.yaml --tags all --skip-tags opendev-validation,external_deploy_steps "$@"

In addition the overcloud_scale_up.log now shows the scale up was limited to just the new node being added:

PLAY RECAP *********************************************************************
compute-2                  : ok=312  changed=167  unreachable=0    failed=0    skipped=120  rescued=0    ignored=0   

Monday 08 June 2020  16:53:32 -0400 (0:00:00.113)       0:11:39.275 *********** 
=============================================================================== 

Ansible passed.
Overcloud configuration completed.
Overcloud Endpoint: http://10.0.0.121:5000
Overcloud Horizon Dashboard URL: http://10.0.0.121:80/dashboard
Overcloud rc file: /home/stack/overcloudrc
Overcloud Deployed
Comment 8 Alex McLeod 2020-06-16 12:29:49 UTC 
If this bug requires doc text for errata release, please set the 'Doc Type' and provide draft text according to the template in the 'Doc Text' field. The documentation team will review, edit, and approve the text.

If this bug does not require doc text, please set the 'requires_doc_text' flag to '-'.
Comment 10 errata-xmlrpc 2020-07-29 07:52:57 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3148