Bug 1840194
| Summary: | /usr/share/systemtap/tapset/sssd_functions.stp missing a comma | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | William Cohen <wcohen> | ||||
| Component: | sssd | Assignee: | avisiedo <avisiedo> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | abokovoy, atikhono, avisiedo, jhrozek, lslebodn, mzidek, pbrezina, rharwood, sbose, ssorce, thalman | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | sync-to-jira | ||||||
| Fixed In Version: | sssd-2.3.1-2.fc32 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1850961 (view as bug list) | Environment: | |||||
| Last Closed: | 2020-07-30 18:56:43 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1850961 | ||||||
| Attachments: |
|
||||||
Also see the same problem with the sssd_functions.stp file on F32 with sssd-common-2.3.0-1.fc32.x86_64. Hi William, Thank you very much for spotting this issue and your patch. I will push the changes as soon as possible. Best regards Whiteboard: sync-to-jira Upstream PR: https://github.com/SSSD/sssd/pull/5202 Pushed PR: https://github.com/SSSD/sssd/pull/5202 * `master` * 66029529fa0f0e2d16999f22294822deeec5f60b - systemtap: Missing a comma FEDORA-2020-63a418c824 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-63a418c824 FEDORA-2020-63a418c824 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-63a418c824` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-63a418c824 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-63a418c824 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |
Created attachment 1692292 [details] patch to insert missing comma in file Description of problem: When running systemtap testsuite on fedora rawhide I saw a lot of failures. Like the following: FAIL: abort: TEST 5: abort() in the middle of a probe handler body (--compatible 3.3): stderr: fails to match regex "^semantic error: unresolved function \(similar: [^\n]*?\): identifier 'abort' at [^\n]*?\.stp:3:5\n": got "parse error: expected 'probe', 'global', 'private', 'function', or '%{' saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34 source: METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10 ^ 1 parse error. WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped Pass 2: analysis failed. [man error::pass2] " FAIL: abort: TEST 7: abort() in timer.profile (more concurrency and no globals): stderr: string should be "", but got "parse error: expected 'probe', 'global', 'private', 'function', or '%{' saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34 source: METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10 ^ 1 parse error. WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped " Version-Release number of selected component (if applicable): How reproducible: every time Steps to Reproduce: 1. dnf install systemtap-testsuite kernel-devel 2. dnf debuginfo kernel 3. sudo stap -e 'probe timer.profile { abort(); error("fire after abort!\n") }' Actual results: parse error: expected 'probe', 'global', 'private', 'function', or '%{' saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34 source: METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10 ^ 1 parse error. WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped Expected results: $ sudo stap -e 'probe timer.profile { abort(); error("fire after abort!\n") }' Additional info: Looks like a trivial missing comma to fix the issue.