Bug 1850961

+++ This bug was initially created as a clone of Bug #1840194 +++

Description of problem:

When running systemtap testsuite on fedora rawhide I saw a lot of failures. Like the following:

FAIL: abort: TEST 5: abort() in the middle of a probe handler body (--compatible 3.3): stderr: fails to match regex "^semantic error: unresolved function \(similar: [^\n]*?\): identifier 'abort' at [^\n]*?\.stp:3:5\n": got "parse error: expected 'probe', 'global', 'private', 'function', or '%{'
        saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
     source:        METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
                                              ^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped
Pass 2: analysis failed.  [man error::pass2]
"
FAIL: abort: TEST 7: abort() in timer.profile (more concurrency and no globals): stderr: string should be "", but got "parse error: expected 'probe', 'global', 'private', 'function', or '%{'
        saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
     source:        METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
                                              ^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped
"


Version-Release number of selected component (if applicable):


How reproducible:

every time


Steps to Reproduce:
1. dnf install systemtap-testsuite kernel-devel
2. dnf debuginfo kernel
3.  sudo stap -e 'probe timer.profile { 
    abort();
    error("fire after abort!\n")
}'


Actual results:


parse error: expected 'probe', 'global', 'private', 'function', or '%{'
        saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
     source:        METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
                                              ^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped


Expected results:

$ sudo stap -e 'probe timer.profile { 
    abort();
    error("fire after abort!\n")
}'



Additional info:

Looks like a trivial missing comma to fix the issue.

--- Additional comment from William Cohen on 2020-05-26 14:51:50 UTC ---

Also see the same problem with the sssd_functions.stp file on F32 with sssd-common-2.3.0-1.fc32.x86_64.

--- Additional comment from avisiedo on 2020-06-11 07:58:45 UTC ---

Hi William,

Thank you very much for spotting this issue and your patch. I will push the changes as soon as possible.

Best regards

Whiteboard: sync-to-jira

--- Additional comment from Alexey Tikhonov on 2020-06-25 08:24:39 UTC ---

Upstream PR: https://github.com/SSSD/sssd/pull/5202