Bug 1841909

Summary: import from git flow does not validate custom git repository
Product: OpenShift Container Platform Reporter: cvogt
Component: Dev ConsoleAssignee: Aritra Roy <ariroy>
Status: CLOSED ERRATA QA Contact: Gajanan More <gamore>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5CC: aos-bugs, ariroy, nmukherj, sgarciam, tommi.tuura, viraj
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1893022 (view as bug list) Environment:
Last Closed: 2020-10-27 16:01:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1893022    
Attachments:
Description Flags
validate git url on selecting git type none

Description cvogt 2020-05-29 19:24:58 UTC 
Description of problem:
Custom Git repositories are not validated during git import flows unless the repo URL is from `github`, `gitlab` or `bitbucket`.


Version-Release number of selected component (if applicable):
4.5.0-0.ci-2020-05-26-143043

How reproducible:


Steps to Reproduce:
1. Go to dev perspective -> Import from Git
2. Enter git URL `https://version.helsinki.fi/tommi.tuura/public-project`
3. Select Git Type `GitLab`

Actual results:
Error `Git repository is not reachable`.


Expected results:
Once the Git Type is entered correctly, the validation should re-run.


Additional info:
Comment 2 cvogt 2020-06-08 16:37:40 UTC 
After the git type is selected, validation should be re-run and if successful, the help text should reflect the successful validation.
Furthermore, for the git import flow, the builder image detection should re-run after successfully connecting to the git repository using the git APIs.
Comment 3 Aritra Roy 2020-06-10 02:05:08 UTC 
Created attachment 1696428 [details]
validate git url on selecting git type
Comment 7 Sergio G. 2020-10-06 08:22:17 UTC 
Is there any backport planned for 4.5?
Comment 10 Sergio G. 2020-10-26 07:27:01 UTC 
Is there any backport planned for 4.5?
Comment 11 errata-xmlrpc 2020-10-27 16:01:56 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196
Comment 12 Sergio G. 2020-10-28 08:23:23 UTC 
No backport to 4.5?
Comment 13 Aritra Roy 2020-10-28 15:42:59 UTC 
Hi @sgarciam,
A backport to 4.5 has been initialized and will be put up soon.
Thank you for your patience.