Bug 1848425

Summary:	Affinity modal closes when user attempts to edit existing rule with [Exists, DoesNotExist] operator
Product:	OpenShift Container Platform	Reporter:	Radim Hrazdil <rhrazdil>
Component:	Console Kubevirt Plugin	Assignee:	Gilad Lekner <glekner>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.5	CC:	aos-bugs, gouyang, openshift-bugzilla-robot, tjelinek, yzamir
Target Milestone:	---
Target Release:	4.5.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1848418	Environment:
Last Closed:	2020-07-22 12:20:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1848418
Bug Blocks:

Description Radim Hrazdil 2020-06-18 11:11:13 UTC

+++ This bug was initially created as a clone of Bug #1848418 +++

Description of problem:

When an affinity rule is added with Exists or DoesNotExist operators, the affinity modal closes when user tries to edit such rule.
Error in terminal:
Uncaught error Uncaught TypeError: Cannot read property 'map' of undefined


Version-Release number of selected component (if applicable):
console/release-4.5 and console/master
OCP 4.4.5
CNV 2.3


How reproducible:
100%

Steps to Reproduce:
1. Add affinity rule with node selector 'test' and operator DoesNotExist
2. Save, Save
3. Open Affinity modal dialog and try to edit the affinity rule

Actual results:
Affinity modal is closed

Expected results:


Additional info:

Comment 3 Radim Hrazdil 2020-06-24 08:19:09 UTC

I can verify that rule added with Exists or DoesNotExist operators can be deleted and edited without issue, however, rules with In and NotIn operator are now causing the following error when I try to delete them (kebab -> delete -> Save)

Danger alert:An error occurred
Error "spec.template.spec.affinity in body must be of type object: "null"" for field "undefined".

@Kobi, please advise, should I move to assigned and retaget 4.5.z?

Comment 4 Yaacov Zamir 2020-06-24 08:47:17 UTC

Thanks, yes.

Comment 5 Yaacov Zamir 2020-06-24 09:04:06 UTC

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1848418

Comment 6 Yaacov Zamir 2020-06-30 10:43:31 UTC

*** Bug 1852392 has been marked as a duplicate of this bug. ***

Comment 7 Yaacov Zamir 2020-06-30 10:47:36 UTC

submitted upstream: https://github.com/openshift/console/pull/5858

Comment 9 Tomas Jelinek 2020-07-10 05:39:04 UTC

patch ready, just waiting for 4.5.z to open to be merged.

Comment 12 Guohua Ouyang 2020-07-20 06:54:30 UTC

verified on upstream 4.5 branch which has PR #5858 included, the issue is fixed.

Comment 14 errata-xmlrpc 2020-07-22 12:20:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2956