Bug 1849568

Summary:	Review Request: sourcetrail - a free and open-source interactive source explorer
Product:	[Fedora] Fedora	Reporter:	serge_sans_paille <sguelton>
Component:	Package Review	Assignee:	Tom Stellard <tstellar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	kkleine, package-review, tstellar
Target Milestone:	---	Flags:	tstellar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-23 06:25:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description serge_sans_paille 2020-06-22 09:19:49 UTC

Spec URL: https://sergesanspaille.fedorapeople.org/sourcetrail.spec
SRPM URL: https://sergesanspaille.fedorapeople.org/sourcetrail-2020.1.117-1.fc33.src.rpm
Description: Sourcetrail is a free and open-source cross-platform source explorer that helps you get productive on unfamiliar source code.
Fedora Account System Username: sergesanspaille

Comment 1 serge_sans_paille 2020-06-22 09:20:33 UTC

This is my first time packaging a graphical application, Can't say If I missed something on the xdg-desktop aspects...

Comment 2 Konrad Kleine 2020-06-22 10:47:57 UTC

As mentioned on IRC, when installing this on Fedora 32 I get this error:

$ dnf install https://sergesanspaille.fedorapeople.org/sourcetrail-2020.1.117-1.fc33.x86_64.rpm 
Last metadata expiration check: 0:11:59 ago on Mon 22 Jun 2020 10:37:00 AM CEST.
sourcetrail-2020.1.117-1.fc33.x86_64.rpm                                                2.0 MB/s | 3.3 MB     00:01    
Error: 
 Problem: conflicting requests
  - nothing provides libboost_filesystem.so.1.73.0()(64bit) needed by sourcetrail-2020.1.117-1.fc33.x86_64
  - nothing provides libboost_program_options.so.1.73.0()(64bit) needed by sourcetrail-2020.1.117-1.fc33.x86_64
(try to add '--skip-broken' to skip uninstallable packages)

Comment 3 Tom Stellard 2020-06-22 14:56:12 UTC

Since this project uses CMake, you should try to align the spec file with this proposal: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds .  I don't know if all the new macros exist, but you could at least adopt the convention of not cd'ing into the build directory.  And also use _vpath_builddir macro for the build directory.

Comment 4 Tom Stellard 2020-06-25 15:05:09 UTC

Is there a reason why debuginfo is disabled?

Comment 5 serge_sans_paille 2020-06-26 18:28:51 UTC

@KonradKeline: that's because this package is buit for rawhide, which provides a higher version of boost. If this gets built for f32, the dependencies should be satisfied.
@Tom: no reason for debuginfo, and I updated the cmake lines.

Comment 6 serge_sans_paille 2020-07-02 12:07:08 UTC

There has been a release upsteam, that adds support for llvm-10. I've updated the spec etc accordingly.

Spec URL: https://sergesanspaille.fedorapeople.org/sourcetrail.spec
SRPM URL: https://sergesanspaille.fedorapeople.org/sourcetrail-2020.2.43-1.fc33.src.rpm

Comment 7 serge_sans_paille 2020-07-02 12:08:22 UTC

Copr build: https://copr.fedorainfracloud.org/coprs/sergesanspaille/sourcetrail/build/1515392/

Comment 8 Tom Stellard 2020-07-09 14:14:14 UTC

You should add a comment explaining why parallel builds are disabled.  Otherwise, LGTM.

Comment 9 serge_sans_paille 2020-07-15 07:11:10 UTC

Parallel builds are now ok, I updated the uploaded files to reflect that.

Comment 10 Gwyn Ciesla 2020-07-20 15:00:40 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sourcetrail

Comment 11 serge_sans_paille 2020-07-23 06:25:48 UTC

Uploaded as sourcetrail-2020.2.43-1.fc33