Spec URL: https://sergesanspaille.fedorapeople.org/sourcetrail.spec SRPM URL: https://sergesanspaille.fedorapeople.org/sourcetrail-2020.1.117-1.fc33.src.rpm Description: Sourcetrail is a free and open-source cross-platform source explorer that helps you get productive on unfamiliar source code. Fedora Account System Username: sergesanspaille
This is my first time packaging a graphical application, Can't say If I missed something on the xdg-desktop aspects...
As mentioned on IRC, when installing this on Fedora 32 I get this error: $ dnf install https://sergesanspaille.fedorapeople.org/sourcetrail-2020.1.117-1.fc33.x86_64.rpm Last metadata expiration check: 0:11:59 ago on Mon 22 Jun 2020 10:37:00 AM CEST. sourcetrail-2020.1.117-1.fc33.x86_64.rpm 2.0 MB/s | 3.3 MB 00:01 Error: Problem: conflicting requests - nothing provides libboost_filesystem.so.1.73.0()(64bit) needed by sourcetrail-2020.1.117-1.fc33.x86_64 - nothing provides libboost_program_options.so.1.73.0()(64bit) needed by sourcetrail-2020.1.117-1.fc33.x86_64 (try to add '--skip-broken' to skip uninstallable packages)
Since this project uses CMake, you should try to align the spec file with this proposal: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds . I don't know if all the new macros exist, but you could at least adopt the convention of not cd'ing into the build directory. And also use _vpath_builddir macro for the build directory.
Is there a reason why debuginfo is disabled?
@KonradKeline: that's because this package is buit for rawhide, which provides a higher version of boost. If this gets built for f32, the dependencies should be satisfied. @Tom: no reason for debuginfo, and I updated the cmake lines.
There has been a release upsteam, that adds support for llvm-10. I've updated the spec etc accordingly. Spec URL: https://sergesanspaille.fedorapeople.org/sourcetrail.spec SRPM URL: https://sergesanspaille.fedorapeople.org/sourcetrail-2020.2.43-1.fc33.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/sergesanspaille/sourcetrail/build/1515392/
You should add a comment explaining why parallel builds are disabled. Otherwise, LGTM.
Parallel builds are now ok, I updated the uploaded files to reflect that.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sourcetrail
Uploaded as sourcetrail-2020.2.43-1.fc33