Bug 1851029

Summary:	[RFE] Add to time based queries the samples table
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Aviv Litman <alitman>
Component:	ovirt-engine-dwh	Assignee:	Aviv Litman <alitman>
Status:	CLOSED ERRATA	QA Contact:	Ivana Saranova <isaranov>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.4.2	CC:	achareka, aoconnor, dfodor, lleistne, lsurette, mhicks, michal.skrivanek, pelauter, sgoodman, sradco, srevivo
Target Milestone:	ovirt-4.4.3-1	Keywords:	FutureFeature, ZStream
Target Release:	4.4.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Previously, time-based Grafana reports did not include the most recent two to three hours of sample data. With this update, you can now view sample data from that time period. For example, if you ran the report at 11:54, the report had data only until 9:00. Now the report has data until 11:54.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-24 13:12:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Aviv Litman 2020-06-25 13:06:38 UTC

Description of problem:

The time based queries displaying data based on hourly and daily tables, from that reason we can see updated data up to 02:00-02:59 hours back. 
We want to add those missing hours from the sample table.
In addition we want to specify the relevant column names in SELECT statement, to improve query runtime     

Version-Release number of selected component (if applicable):
4.4.1


Actual results:

The issued queries use the hourly and daily tables.
The issued queries use '*' in the SELECT statement. 


Expected results:

The issued queries use the hourly, daily, and samples tables.
The issued queries use relevant column names in the SELECT statement.

Comment 3 Ameya Charekar 2020-10-20 07:57:18 UTC

*** Bug 1889056 has been marked as a duplicate of this bug. ***

Comment 9 Steve Goodman 2020-11-04 08:17:03 UTC

Please review the doc text:

====
Previously, time-based Grafana reports did not include two hours of sample data from hours 02:00-02:59.

With this update, you can now view sample data from those two hours.
===

Comment 10 Aviv Litman 2020-11-04 09:29:36 UTC

(In reply to Steve Goodman from comment #9)
> Please review the doc text:
> 
> ====
> Previously, time-based Grafana reports did not include two hours of sample
> data from hours 02:00-02:59.
> 
> With this update, you can now view sample data from those two hours.
> ===

Hi the description is inaccurate:

Previously, time-based Grafana reports did not include two to three hours of sample
data.

With this update, you can now view sample data from those hours.

Comment 11 Steve Goodman 2020-11-05 08:34:22 UTC

The doc_text is now updated:

Previously, time-based Grafana reports did not include the most recent two to three hours of sample data. With this update, you can now view sample data from that time period.

For example, if you ran the report at 11:54, the report had data only until 9:00. Now the report has data until 11:54.

Comment 12 Ivana Saranova 2020-11-10 23:33:57 UTC

Steps:
1) Go to Grafana, any timebased data sampling dashboard (e.g. Hosts Trend Dashboard)
2) Try various time ranges
3) Check that data is shown up until the current time and not 2-3 hours back

Results:
If minutes or hours time range is selected, the data is shown as expected. 
If Today (or Today so far) is selected, data is shown as expected.
If a time range containing days, weeks, months or years (e.g. Last 2 days, Last 30 days, etc.) was selected, the data is missing for the last 2 hours. 
If This week, This month or This year (and their so far options) are selected, the data is missing for the last 2 hours.

The data is shown for hourly or daily (withing the 24hour range) time ranges, therefore I'm moving this to VERIFIED as it matches the description of the RFE.

Verified in:
ovirt-engine-dwh-4.4.3.2-1.el8ev.noarch
ovirt-engine-4.4.3.10-0.1.el8ev.noarch

Comment 16 errata-xmlrpc 2020-11-24 13:12:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (RHV Manager (ovirt-engine) 4.4.z [ovirt-4.4.3] 0-day), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5215