Bug 1853592

Summary: Missing comma in systemtap/tapset/sssd_functions.stp
Product: Red Hat Enterprise Linux 8 Reporter: Martin Cermak <mcermak>
Component: sssdAssignee: SSSD Maintainers <sssd-maint>
Status: CLOSED DUPLICATE QA Contact: sssd-qe <sssd-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.3CC: atikhono, fche, grajaiya, jhrozek, lslebodn, mzidek, pbrezina, sssd-maint, tscherf
Target Milestone: rc   
Target Release: 8.3   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-03 09:13:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Cermak 2020-07-03 09:03:59 UTC
The sssd_functions.stp coming from sssd-common-2.3.0-2.el8 contains a little syntax error:

=======
global METHOD_CHECK_ONLINE=0, METHOD_ACCOUNT_HANDLER=1, METHOD_AUTH_HANDLER=2,
       METHOD_ACCESS_HANDLER=3, METHOD_SELINUX_HANDLER=4, METHOD_SUDO_HANDLER=5,
       METHOD_AUTOFS_HANDLER=6, METHOD_HOSTID_HANDLER=7, METHOD_DOMAINS_HANDLER=8,
       METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
=======

Note the missing comma before "METHOD_SENTINEL=10".


This little syntax error is causing that almost any systemtap user (having sssd-common installed) will see following "welcome" message when using systemtap in pretty much any way, for example:

=======
  8.3 Server x86_64 # stap -L 'syscall.open'
parse error: expected 'probe', 'global', 'private', 'function', or '%{'
        saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
     source:        METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
                                              ^

1 parse error.
syscall.open name:string filename:string flags:long flags_str:string mode:long argstr:string
  8.3 Server x86_64 # 
=======

Please, fix :)

Comment 2 Alexey Tikhonov 2020-07-03 09:13:04 UTC
Thank you for reporting this issue. I think this is a duplicate of bz 1850961

*** This bug has been marked as a duplicate of bug 1850961 ***