Bug 1854468

Summary: Review Request: rust-libcryptsetup-rs - high level Rust bindings for libcryptsetup
Product: [Fedora] Fedora Reporter: John Baublitz <jbaublitz>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-07 17:10:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John Baublitz 2020-07-07 14:07:59 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jbaublitz/rust-libcryptsetup-rs/fedora-rawhide-x86_64/01523563-rust-libcryptsetup-rs/rust-libcryptsetup-rs.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jbaublitz/rust-libcryptsetup-rs/fedora-rawhide-x86_64/01523563-rust-libcryptsetup-rs/rust-libcryptsetup-rs-0.4.2-1.fc33.src.rpm
Description: High level Rust bindings for libcryptsetup
Fedora Account System Username: jbaublitz

Here is the successful koji build for this crate: https://koji.fedoraproject.org/koji/taskinfo?taskID=46748407

This is the higher level version of rust-libcryptsetup-rs-sys which I just got into rawhide.
Comment 1 Robert-André Mauchin 🐧 2020-07-07 14:34:56 UTC 
 - You must install the license file with %license in files devel and should install the %doc as well:

%files          devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the installation of the license before import.
Comment 2 John Baublitz 2020-07-07 14:53:23 UTC 
Ok the changes have been applied, thank you!
Comment 3 Gwyn Ciesla 2020-07-07 15:00:46 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libcryptsetup-rs