Bug 1854468 - Review Request: rust-libcryptsetup-rs - high level Rust bindings for libcryptsetup
Summary: Review Request: rust-libcryptsetup-rs - high level Rust bindings for libcrypt...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-07 14:07 UTC by John Baublitz
Modified: 2020-07-07 17:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-07 17:10:47 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description John Baublitz 2020-07-07 14:07:59 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jbaublitz/rust-libcryptsetup-rs/fedora-rawhide-x86_64/01523563-rust-libcryptsetup-rs/rust-libcryptsetup-rs.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jbaublitz/rust-libcryptsetup-rs/fedora-rawhide-x86_64/01523563-rust-libcryptsetup-rs/rust-libcryptsetup-rs-0.4.2-1.fc33.src.rpm
Description: High level Rust bindings for libcryptsetup
Fedora Account System Username: jbaublitz

Here is the successful koji build for this crate: https://koji.fedoraproject.org/koji/taskinfo?taskID=46748407

This is the higher level version of rust-libcryptsetup-rs-sys which I just got into rawhide.

Comment 1 Robert-André Mauchin 🐧 2020-07-07 14:34:56 UTC
 - You must install the license file with %license in files devel and should install the %doc as well:

%files          devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the installation of the license before import.

Comment 2 John Baublitz 2020-07-07 14:53:23 UTC
Ok the changes have been applied, thank you!

Comment 3 Gwyn Ciesla 2020-07-07 15:00:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libcryptsetup-rs


Note You need to log in before you can comment on or make changes to this bug.