Bug 1855818

Summary: Pipeline Trigger Resource YAMLs should be Editable
Product: OpenShift Container Platform Reporter: Andrew Ballantyne <aballant>
Component: Dev ConsoleAssignee: Andrew Ballantyne <aballant>
Status: CLOSED ERRATA QA Contact: spathak <spathak>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5CC: aos-bugs, cjerolim, nmukherj, spathak
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:13:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1855820    
Attachments:
Description Flags
Pipeline Trigger Resource YAMLs is Editable none

Description Andrew Ballantyne 2020-07-10 15:17:29 UTC
Description of problem:
When I access a TriggerTemplate by clicking on the link to it in the Pipeline Details screen, I can then select the option to Edit the TriggerTemplate. This redirects me to a YAML editor but I can't save my changes.

Prerequisites (if any, like setup, operators/versions):
Pipelines Operator 1.0.1, OpenShift 4.5.0-rc.4

Steps to Reproduce
1. From the Pipelines list in the Developer console, click on a Pipeline that has a Trigger
2. Click on the TriggerTemplate
3. In the TriggerTemplate Details screen, select "Edit Trigger Template" from the dropdown menu
4. The YAML editor opens up but in read-only mode

Actual results:
The editor opens up in read-only mode. I can't do changes and there is no save button.

Expected results:
I should be able to edit the Trigger Template. If this screen is meant to be read-only, then perhaps the wording should change from "Edit Trigger Template" to "View Trigger Template YAML file"

Reproducibility (Always/Intermittent/Only Once):
Always

Build Details:
Additional info:
We should make all trigger resources editable at the same time:

Event Listener
Cluster Trigger Binding
Trigger Binding
(and) Trigger Template

Comment 3 Christoph Jerolimov 2020-09-02 14:16:49 UTC
This issue was solved here: https://github.com/openshift/console/pull/5937

Comment 4 spathak@redhat.com 2020-09-03 20:38:04 UTC
Created attachment 1713679 [details]
Pipeline Trigger Resource YAMLs is Editable

Comment 5 spathak@redhat.com 2020-09-03 20:38:59 UTC
Verified on build version:4.6.0-0.nightly-2020-09-03-084733
Browser version: Chrome 84

Comment 7 errata-xmlrpc 2020-10-27 16:13:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196