Bug 1856002

Summary: dwh setup automatically restarts ovirt-engine and still asks the user to do it manually
Product: [oVirt] ovirt-engine-dwh Reporter: Lucie Leistnerova <lleistne>
Component: SetupAssignee: Yedidyah Bar David <didi>
Status: CLOSED WONTFIX QA Contact: Lucie Leistnerova <lleistne>
Severity: low Docs Contact:
Priority: medium    
Version: 4.4.1.2CC: bugs, pelauter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-20 07:07:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lucie Leistnerova 2020-07-11 17:27:54 UTC
Description of problem:
When installing dwn on separate machine, setup asks about restarting the ovirt-engine automatically. User says Yes, engine is restarted, but still in the end of the setup it asks to do it manually.

Version-Release number of selected component (if applicable):
ovirt-engine-dwh-setup-4.4.1.2-1.el8ev.noarch

How reproducible: always


Steps to Reproduce:
1. install dwh on separate machine
2. answer 'Yes' to 
The engine should be restarted for Single-Sign-On (SSO) to work. Do this as part of Setup? If not, you will have to do this later by yourself
3.

Actual results:
setup output contains
          Please restart the engine by running the following on <engine fqdn> :
          # service ovirt-engine restart
          This is required for the dashboard to work.


Expected results: no restart information


Additional info:
When user answers 'No', there is this restart info twice
+
          Please run the following command on the engine machine <engine fqdn>, for SSO to work:
          systemctl restart ovirt-engine

Comment 1 Yedidyah Bar David 2020-07-16 13:51:21 UTC
These are two separate issues - one is done for dwh (so that the dashboard works), other for grafana (so that SSO works, until we fix bug 1846294 - then we should remove this part).

The right solution is probably to add code to engine-common plugin to do a remote restart of the engine, conditionally, and allow other plugins to set the condition. I need to think a bit about this - especially about the texts - we probably want to show all of them, e.g.:

The remote engine should be restarted for these reasons:
- Grafana SSO
- Admin UI dashboard

And collect the actual reasons (the bulleted lines) from the plugins.

Comment 2 Yedidyah Bar David 2020-07-16 13:53:15 UTC
This means that it will require patches for both the engine and dwh.

BTW, not always you run into this - if you e.g. setup engine+dwh on one machine, and grafana on another (not sure we decided to support this officially, but it should work, more-or-less), you'll only see the text/prompt from grafana.