Bug 1856155

Summary: Pipeline Builder - Tasks Disconnect on Delete
Product: OpenShift Container Platform Reporter: Andrew Ballantyne <aballant>
Component: Dev ConsoleAssignee: Andrew Ballantyne <aballant>
Status: CLOSED ERRATA QA Contact: spathak <spathak>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.5CC: aos-bugs, cjerolim, nmukherj, spathak
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Failure to maintain the connection between nodes in the Pipeline Builder when deleting a middle node. This only occurred when a task that was to be deleted had a runAfter and was part of another's runAfter (ie they had more than one runAfter). Consequence: It would break the connection flow between the tasks Fix: Properly maintain the connection when a middle node was removed. Result: Maintains the connection during delete.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:13:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1856156    
Attachments:
Description Flags
Pipeline Builder - Tasks do not Disconnect on Delete none

Description Andrew Ballantyne 2020-07-13 00:59:42 UTC 
Description:
Tasks rearrange incorrectly in Pipeline Builder page on adding or deleting tasks.

Deleting a sequential task in a parallel chain of tasks removes the connector between the involved parallel tasks
Adding a sequential task to one of independent chains of tasks causes shuffling in the row arrangements of the chains of tasks.

Build: 4.5.0-0.ci-2020-05-18-204038
Browser: Firefox (version 75)

Reproducibility: Always

Steps to reproduce:

1. go to Pipeline Page and click on Create Pipeline button
2. Add a task T1 and a sequential task T2 to it
3. Add a parallel task T11 to the first task
4. Add a sequential task T12 to the newly added parallel task T11
5. Remove the sequential task T12
6. Add more tasks to either of the chains of tasks

Actual Behaviour:

The parallel chain of tasks breaks off as an independent chain losing the connector between the parallel tasks.
On adding more tasks to either chain, the chains rearrange

Expected Behaviour:

The parallel tasks should be reconnected with the connector on deletion of a task
The positions of the chains should not rearrange
Comment 3 Christoph Jerolimov 2020-09-02 14:17:24 UTC 
This issue was solved here: https://github.com/openshift/console/pull/5934
Comment 4 spathak@redhat.com 2020-09-03 19:03:20 UTC 
Created attachment 1713670 [details]
Pipeline Builder - Tasks do not Disconnect on Delete
Comment 5 spathak@redhat.com 2020-09-03 19:20:17 UTC 
Verified on build version:4.6.0-0.nightly-2020-09-03-084733
Browser version: Chrome 84
Comment 7 errata-xmlrpc 2020-10-27 16:13:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196