Bug 1856552

Summary:	Review Request: jchardet - Java port of Mozilla's automatic character set detection algorithm
Product:	[Fedora] Fedora	Reporter:	Mat Booth <mat.booth>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-14 13:01:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1856554

Description Mat Booth 2020-07-13 22:28:41 UTC

Spec URL: https://fedorapeople.org/~mbooth/reviews/jchardet.spec
SRPM URL: https://fedorapeople.org/~mbooth/reviews/jchardet-1.1-20.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
jchardet is a java port of the source from Mozilla's automatic charset
detection algorithm. The original author is Frank Tang. What is available
here is the java port of that code. The original source in C++ can be found
from http://lxr.mozilla.org/mozilla/source/intl/chardet/. More information can
be found at http://www.mozilla.org/projects/intl/chardet.html.

Comment 1 Mat Booth 2020-07-13 22:56:36 UTC

This is a re-review for unretirement: https://pagure.io/releng/issue/9595

Comment 2 Fabio Valentini 2020-07-14 09:25:01 UTC

One small issue:

Please use https links for Source1 (maven central isn't even reachable via plain http any longer).
I'm not sure if sourceforge provides https links for downloads, but if it does, please use https for Source0 as well.

Otherwise, looks good. Pretty standard Java packaging stuff in here ...
The package also has correct upgrade path over all previously available versions.

Be aware that if you want to reintroduce the package on some non-modular branch other than rawhide, you'll have to request f32 / f31 branches after the unretirement request went through (since jchardet was retired before the f31 branch point).

Package APPROVED (but please fix the Source0/1 HTTPS URL before importing).

Comment 3 Fabio Valentini 2020-07-14 09:46:19 UTC

Oh, side note: If you're building this for rawhide before the Java 11 side tag is merged (which is likely), you should probably build it with "fedpkg build --target f33-java11".

Comment 4 Mat Booth 2020-07-14 10:03:42 UTC

(In reply to Fabio Valentini from comment #2)
> 
> Package APPROVED (but please fix the Source0/1 HTTPS URL before importing).

Thanks, will do.

Comment 5 Mat Booth 2020-07-14 13:01:08 UTC

Rawhide build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1541665