Spec URL: https://fedorapeople.org/~mbooth/reviews/jchardet.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/jchardet-1.1-20.fc33.src.rpm Fedora Account System Username: mbooth Description: jchardet is a java port of the source from Mozilla's automatic charset detection algorithm. The original author is Frank Tang. What is available here is the java port of that code. The original source in C++ can be found from http://lxr.mozilla.org/mozilla/source/intl/chardet/. More information can be found at http://www.mozilla.org/projects/intl/chardet.html.
This is a re-review for unretirement: https://pagure.io/releng/issue/9595
One small issue: Please use https links for Source1 (maven central isn't even reachable via plain http any longer). I'm not sure if sourceforge provides https links for downloads, but if it does, please use https for Source0 as well. Otherwise, looks good. Pretty standard Java packaging stuff in here ... The package also has correct upgrade path over all previously available versions. Be aware that if you want to reintroduce the package on some non-modular branch other than rawhide, you'll have to request f32 / f31 branches after the unretirement request went through (since jchardet was retired before the f31 branch point). Package APPROVED (but please fix the Source0/1 HTTPS URL before importing).
Oh, side note: If you're building this for rawhide before the Java 11 side tag is merged (which is likely), you should probably build it with "fedpkg build --target f33-java11".
(In reply to Fabio Valentini from comment #2) > > Package APPROVED (but please fix the Source0/1 HTTPS URL before importing). Thanks, will do.
Rawhide build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1541665