Bug 1857199

Summary:	Review Request: mozjs78 - JavaScript interpreter and libraries
Product:	[Fedora] Fedora	Reporter:	František Zatloukal <fzatlouk>
Component:	Package Review	Assignee:	Kalev Lember <klember>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	klember, package-review
Target Milestone:	---	Flags:	klember: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-04 06:05:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description František Zatloukal 2020-07-15 12:32:43 UTC

SPEC: https://gist.github.com/frantisekz/52551d4f22f4e6a127aa5d2d4411a401
SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/mozjs78/srpm-builds/01554533/mozjs78-78.0.2-1.fc32.src.rpm

Description: 
SpiderMonkey is the code-name for Mozilla Firefox's C++ implementation of JavaScript. It is intended to be embedded in other applications that provide host environments for JavaScript.

It's based on mozjs68 package: https://src.fedoraproject.org/rpms/mozjs68

This is probably going to need some more fixing for arm/ppc/s390 arches which I am planning to work on in a few days. I think this can be done before/after the package review. I've tested this only on x86_64 for now.

LTO will be enabled at later point too to make developing and rebuilding faster right now before anything else depends on it.

New GNOME Shell is going to require this: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/458

New polkit is going to require this:
https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/58

Comment 1 František Zatloukal 2020-07-23 08:29:46 UTC

SPEC: https://gist.github.com/frantisekz/52551d4f22f4e6a127aa5d2d4411a401
SRPM: https://kojipkgs.fedoraproject.org//work/tasks/7627/47627627/mozjs78-78.0.2-1.fc33.src.rpm

Koji Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=47627625

I've fixed issues on armv7 and s390x.

Comment 2 František Zatloukal 2020-07-28 16:46:15 UTC

SPEC: https://gist.github.com/frantisekz/52551d4f22f4e6a127aa5d2d4411a401
SRPM: https://kojipkgs.fedoraproject.org//work/tasks/6399/48026399/mozjs78-78.1.0-1.fc33.src.rpm

Updated to 78.1.0 .

Comment 3 Kalev Lember 2020-07-31 14:22:19 UTC

This looks fine to me. I won't do a full review here as the packaging guidelines don't require a full review when packaging a new parallel installable version of the same library.

Some notes:

1)
> # typedarray-arg-set-values-same-buffer-other-type.js is failing on s390x
> %ifarch s390x s390
> %global require_tests     0
> %endif

Would be nice to disable the single failing test instead of just disabling all the tests. This way, we know as soon as something regresses in the toolchain etc.

2)
> %files
> %doc README.html

Is there a license file to include? Would be nice to include that if possible.


Beyond that, looks good to me :) Thanks for packaging it up, František!

Comment 4 František Zatloukal 2020-08-03 11:58:23 UTC

Thanks for review, one last update addressing your feedback.

SPEC: https://gist.github.com/frantisekz/52551d4f22f4e6a127aa5d2d4411a401
SRPM: https://kojipkgs.fedoraproject.org//work/tasks/5695/48495695/mozjs78-78.1.0-1.fc33.src.rpm

Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=48495691

Comment 5 Gwyn Ciesla 2020-08-03 13:16:31 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mozjs78