Bug 1857199 - Review Request: mozjs78 - JavaScript interpreter and libraries
Summary: Review Request: mozjs78 - JavaScript interpreter and libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-07-15 12:32 UTC by František Zatloukal
Modified: 2020-08-04 06:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-04 06:05:13 UTC
Type: Bug
Embargoed:
klember: fedora-review+


Attachments (Terms of Use)

Description František Zatloukal 2020-07-15 12:32:43 UTC
SPEC: https://gist.github.com/frantisekz/52551d4f22f4e6a127aa5d2d4411a401
SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/mozjs78/srpm-builds/01554533/mozjs78-78.0.2-1.fc32.src.rpm

Description: 
SpiderMonkey is the code-name for Mozilla Firefox's C++ implementation of JavaScript. It is intended to be embedded in other applications that provide host environments for JavaScript.

It's based on mozjs68 package: https://src.fedoraproject.org/rpms/mozjs68

This is probably going to need some more fixing for arm/ppc/s390 arches which I am planning to work on in a few days. I think this can be done before/after the package review. I've tested this only on x86_64 for now.

LTO will be enabled at later point too to make developing and rebuilding faster right now before anything else depends on it.

New GNOME Shell is going to require this: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/458

New polkit is going to require this:
https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/58

Comment 3 Kalev Lember 2020-07-31 14:22:19 UTC
This looks fine to me. I won't do a full review here as the packaging guidelines don't require a full review when packaging a new parallel installable version of the same library.

Some notes:

1)
> # typedarray-arg-set-values-same-buffer-other-type.js is failing on s390x
> %ifarch s390x s390
> %global require_tests     0
> %endif

Would be nice to disable the single failing test instead of just disabling all the tests. This way, we know as soon as something regresses in the toolchain etc.

2)
> %files
> %doc README.html

Is there a license file to include? Would be nice to include that if possible.


Beyond that, looks good to me :) Thanks for packaging it up, František!

Comment 5 Gwyn Ciesla 2020-08-03 13:16:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mozjs78


Note You need to log in before you can comment on or make changes to this bug.