Bug 1857295

Summary: Prevent removing non-empty tag by removing tagged resource group or clone
Product: Red Hat Enterprise Linux 8 Reporter: Michal Mazourek <mmazoure>
Component: pcsAssignee: Miroslav Lisik <mlisik>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: cfeist, cluster-maint, idevat, mlisik, mpospisi, omular, tojeline
Target Milestone: rc   
Target Release: 8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.10.6-3.el8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 02:28:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed fix + tests none

Description Michal Mazourek 2020-07-15 15:34:07 UTC 
Description of problem: 
Tag that contains resource group/clone and other resources is removed, when the tagged resource group/clone is removed.


Version-Release number of selected component (if applicable): 
pcs-0.10.6-2.el8


How reproducible:
Always


Steps to Reproduce:
> [root@virt-125 ~]# pcs resource group add G1 dummy1 dummy2
> [root@virt-125 ~]# pcs tag create GroupTag G1 dummy3
> [root@virt-125 ~]# pcs tag
> GroupTag
>   G1
>   dummy3
> [root@virt-125 ~]# pcs resource ungroup G1
> [root@virt-125 ~]# pcs tag
>  No tags defined


Actual results:
Non-empty tag is deleted


Expected results:
Non-empty tag is not deleted
Comment 1 Miroslav Lisik 2020-07-17 10:31:15 UTC 
Created attachment 1701533 [details]
proposed fix + tests

Affected commands:
* pcs resource ungroup
* pcs resource group remove
* pcs resource group delete
* pcs resource unclone

After removing cloned or group resources from tags, non-empty tags should not be removed.
Comment 2 Miroslav Lisik 2020-07-17 17:04:45 UTC 
Test:

[root@r8-node-01 ~]# rpm -q pcs
pcs-0.10.6-3.el8.x86_64

[root@r8-node-01 ~]# pcs resource
  * Clone Set: DummyForClone-clone [DummyForClone]:
    * Started: [ r8-node-01 r8-node-02 ]
  * OtherDummy	(ocf::pacemaker:Dummy):	 Started r8-node-01
[root@r8-node-01 ~]# pcs tag
CloneTagToRemove
  DummyForClone-clone
TagToRemainAfterUnclone
  OtherDummy
  DummyForClone-clone
[root@r8-node-01 ~]# pcs resource unclone DummyForClone-clone
[root@r8-node-01 ~]# pcs tag
TagToRemainAfterUnclone
  OtherDummy
Comment 8 errata-xmlrpc 2020-11-04 02:28:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4617