RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem: 
Tag that contains resource group/clone and other resources is removed, when the tagged resource group/clone is removed.


Version-Release number of selected component (if applicable): 
pcs-0.10.6-2.el8


How reproducible:
Always


Steps to Reproduce:
> [root@virt-125 ~]# pcs resource group add G1 dummy1 dummy2
> [root@virt-125 ~]# pcs tag create GroupTag G1 dummy3
> [root@virt-125 ~]# pcs tag
> GroupTag
>   G1
>   dummy3
> [root@virt-125 ~]# pcs resource ungroup G1
> [root@virt-125 ~]# pcs tag
>  No tags defined


Actual results:
Non-empty tag is deleted


Expected results:
Non-empty tag is not deleted

Created attachment 1701533 [details]
proposed fix + tests

Affected commands:
* pcs resource ungroup
* pcs resource group remove
* pcs resource group delete
* pcs resource unclone

After removing cloned or group resources from tags, non-empty tags should not be removed.

Test:

[root@r8-node-01 ~]# rpm -q pcs
pcs-0.10.6-3.el8.x86_64

[root@r8-node-01 ~]# pcs resource
  * Clone Set: DummyForClone-clone [DummyForClone]:
    * Started: [ r8-node-01 r8-node-02 ]
  * OtherDummy	(ocf::pacemaker:Dummy):	 Started r8-node-01
[root@r8-node-01 ~]# pcs tag
CloneTagToRemove
  DummyForClone-clone
TagToRemainAfterUnclone
  OtherDummy
  DummyForClone-clone
[root@r8-node-01 ~]# pcs resource unclone DummyForClone-clone
[root@r8-node-01 ~]# pcs tag
TagToRemainAfterUnclone
  OtherDummy

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4617