Bug 1858381

Summary: Review Request: perl-Web-Machine - Perl port of Webmachine
Product: [Fedora] Fedora Reporter: Ralf Corsepius <rc040203>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-18 00:45:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1858360    
Bug Blocks: 201449, 1858048    

Description Ralf Corsepius 2020-07-17 17:39:31 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Web-Machine.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Web-Machine-0.17-1.fc33.src.rpm
Description:
Web::Machine provides a RESTful web framework modeled as a state machine.
You define one or more resource classes. Each resource represents a single
RESTful URI end point, such as a user, an email, etc. The resource class
can also be the target for POST requests to create a new user, email, etc.

Fedora Account System Username: corsepiu

Remark: This package is a new requirement of rt >= 5.0.0

Comment 1 Robert-André Mauchin 🐧 2020-07-18 18:03:36 UTC
Hello Ralf

Could you please update your Perl SPEC to follow the latest Perl-SIG standards, see these recent SPECs https://bugzilla.redhat.com/show_bug.cgi?id=1856854 or https://bugzilla.redhat.com/show_bug.cgi?id=1856839

Basically something like this:


BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76

[…]

%prep
%setup -q -n ColorThemeRole-ANSI-%{version}

%build
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
%{make_build}

%install
%{make_install}
%{_fixperms} $RPM_BUILD_ROOT/*

%check
unset AUTHOR_TESTING
make test


i.e.using NO_PACKLIST=1 NO_PERLLOCAL=1 to use %{make_install} and unset AUTHOR_TESTING for the tests.


 - Add a BR for perl-interpreter: BuildRequires:  perl-interpreter

 - Do not use %{__perl} but perl directly. Macros starting with __ are reserved for rpm private use.

Comment 2 Package Review 2021-07-19 00:45:18 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Package Review 2021-08-18 00:45:30 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.