Bug 1856854 - Review Request: perl-ColorThemeRole-ANSI - Roles for using ColorTheme::* with ANSI codes
Summary: Review Request: perl-ColorThemeRole-ANSI - Roles for using ColorTheme::* with...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1856839
Blocks: 1856759
TreeView+ depends on / blocked
 
Reported: 2020-07-14 15:01 UTC by Jitka Plesnikova
Modified: 2020-07-14 20:02 UTC (History)
2 users (show)

Fixed In Version: perl-ColorThemeRole-ANSI-0.001-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-14 20:02:03 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2020-07-14 15:01:41 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-ColorThemeRole-ANSI/perl-ColorThemeRole-ANSI.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-ColorThemeRole-ANSI/perl-ColorThemeRole-ANSI-0.001-1.fc33.src.rpm

Description:
This module can be mixed in with a ColorTheme::* class. Handy when using
color theme in terminal.

Fedora Account System Username: jplesnik

Comment 1 Robert-André Mauchin 🐧 2020-07-14 16:14:26 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 5821cf0b40aa11913992c3b832201aa309a38cb99cab7fea357d6ed8d5ca211a) is original. Ok.
Summary verified from lib/ColorThemeRole/ANSI.pm. Ok.
Description verified. Ok.
License verified from README and lib/ColorThemeRole/ANSI.pm. Ok.
No XS code, noarch BuildArch is Ok.

Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.
AUTHOR_TESTING variable is unset before executing "make test". Ok.

$ rpmlint perl-ColorThemeRole-ANSI.spec  review-perl-ColorThemeRole-ANSI/results/perl-ColorThemeRole-ANSI-0.001-1.fc33.noarch.rpm  review-perl-ColorThemeRole-ANSI/results/perl-ColorThemeRole-ANSI-0.001-1.fc33.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p review-perl-ColorThemeRole-ANSI/results/perl-ColorThemeRole-ANSI-0.001-1.fc33.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jul 14 18:08 /usr/share/doc/perl-ColorThemeRole-ANSI
-rw-r--r--    1 root     root                      106 Jun  9 10:24 /usr/share/doc/perl-ColorThemeRole-ANSI/Changes
-rw-r--r--    1 root     root                     1293 Jun  9 10:24 /usr/share/doc/perl-ColorThemeRole-ANSI/README
drwxr-xr-x    2 root     root                        0 Jul 14 18:08 /usr/share/licenses/perl-ColorThemeRole-ANSI
-rw-r--r--    1 root     root                    18367 Jun  9 10:24 /usr/share/licenses/perl-ColorThemeRole-ANSI/LICENSE
-rw-r--r--    1 root     root                     1794 Jul 14 18:08 /usr/share/man/man3/ColorThemeRole::ANSI.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul 14 18:08 /usr/share/perl5/vendor_perl/ColorThemeRole
-rw-r--r--    1 root     root                     1811 Jun  9 10:24 /usr/share/perl5/vendor_perl/ColorThemeRole/ANSI.pm
File layout ans permissions are Ok.

$ rpm -q --requires -p review-perl-ColorThemeRole-ANSI/results/perl-ColorThemeRole-ANSI-0.001-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(ColorThemeUtil::ANSI)
      1 perl(Role::Tiny)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p review-perl-ColorThemeRole-ANSI/results/perl-ColorThemeRole-ANSI-0.001-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(ColorThemeRole::ANSI) = 0.001
      1 perl-ColorThemeRole-ANSI = 0.001-1.fc33
Binary provides are Ok.

The package builds in Fedora 33 (in Mock). Ok.

The package is in line with Fedora and Perl packagaging guidelines.

Resolution: Package approved.

Comment 2 Jitka Plesnikova 2020-07-14 19:15:19 UTC
https://pagure.io/releng/fedora-scm-requests/issue/27116


Note You need to log in before you can comment on or make changes to this bug.