Bug 1858486 (rust-zeroize)

Summary:	Review Request: rust-zeroize - Securely clear secrets from memory
Product:	[Fedora] Fedora	Reporter:	Peter Robinson <pbrobinson>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-21 17:54:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1858604
Bug Blocks:	1269538, 1857740, 1859151, 1859159, 1859994

Description Peter Robinson 2020-07-18 10:34:55 UTC

SPEC: https://pbrobinson.fedorapeople.org/rust-zeroize.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-zeroize-1.1.0-1.fc32.src.rpm

Description:
Securely clear secrets from memory with a simple trait built on stable Rust
primitives which guarantee memory is zeroed using an operation will not be
'optimized away' by the compiler. Uses a portable pure Rust implementation that
works everywhere, even WASM!.}

FAS: pbrobinson

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47379345

Comment 1 Robert-André Mauchin 🐧 2020-07-18 16:21:36 UTC

 - Please include the license with %license in %files:

%files          devel
%license LICENSE-MIT
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - Bother upstream for the LICENSE-APACHE file as well: https://github.com/iqlusioninc/crates/issues/475

 - Package is not installable:

DEBUG util.py:621:  Error: 
DEBUG util.py:621:   Problem: conflicting requests
DEBUG util.py:621:    - nothing provides (crate(zeroize_derive/default) >= 1.0.0 with crate(zeroize_derive/default) < 2.0.0) needed by rust-zeroize+zeroize_derive-devel-1.1.0-1.fc33.noarch

Comment 2 Peter Robinson 2020-07-21 09:57:28 UTC

Updated

SPEC: https://pbrobinson.fedorapeople.org/rust-zeroize.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-zeroize-1.1.0-2.fc32.src.rpm

Comment 3 Robert-André Mauchin 🐧 2020-07-21 16:38:12 UTC

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 4 Gwyn Ciesla 2020-07-21 17:01:01 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zeroize