Bug 1857740 (rust-num-bigint-dig) - Review Request: rust-num-bigint-dig - Big integer implementation for Rust
Summary: Review Request: rust-num-bigint-dig - Big integer implementation for Rust
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-num-bigint-dig
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1664161 rust-autocfg rust-zeroize
Blocks: IoT rust-rsa PARSEC
TreeView+ depends on / blocked
 
Reported: 2020-07-16 13:16 UTC by Peter Robinson
Modified: 2020-07-23 14:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-21 19:04:39 UTC
Type: Bug
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Peter Robinson 2020-07-16 13:16:02 UTC
SPEC: https://pbrobinson.fedorapeople.org/rust-num-bigint-dig.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-num-bigint-dig-0.6.0-1.fc32.src.rpm

Description:
Big integer implementation for Rust

FAS: pbrobinson

Comment 1 Robert-André Mauchin 🐧 2020-07-18 15:13:38 UTC
DEBUG util.py:621:  Error: 
DEBUG util.py:621:   Problem: nothing provides requested (crate(autocfg/default) >= 0.1.5 with crate(autocfg/default) < 0.2.0)

We have autocfg 1.0.0 in Fedora. Either try to bump the dependency in Cargo.toml (recommended) or build a autocfg compat package at version 0.1.5. Jistone actually say that version 1.0.0 of autocfg has no breaking changes so bumping the dep will probably work.

Comment 3 Robert-André Mauchin 🐧 2020-07-19 12:54:02 UTC
 - Please don't forget to include the licenses:
Also add the RELEASES.md as %doc

%files          devel
%license LICENSE-APACHE LICENSE-MIT
%doc README.md RELEASES.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - You must include a comment explainig the changes you've made to the metadata and link to an upstream PR including this change:

# Initial patched metadata
# - Bump autocfg to 1.0.0 https://github.com/dignifiedquire/num-bigint/pull/22
Patch0:         num-bigint-dig-fix-metadata.diff

 - The package is not installable:

DEBUG util.py:621:   Problem 1: conflicting requests
DEBUG util.py:621:    - nothing provides (crate(zeroize/zeroize_derive) >= 1.1.0 with crate(zeroize/zeroize_derive) < 2.0.0) needed by rust-num-bigint-dig+zeroize-devel-0.6.0-2.fc33.noarch

zeroize is being packaged so ok

DEBUG util.py:621:   Problem 2: package rust-num-bigint-dig+nightly-devel-0.6.0-2.fc33.noarch requires (crate(rand/nightly) >= 0.7.0 with crate(rand/nightly) < 0.8.0), but none of the providers can be installed
DEBUG util.py:621:    - package rust-rand+nightly-devel-0.7.3-2.fc33.noarch requires crate(rand/simd_support) = 0.7.3, but none of the providers can be installed
DEBUG util.py:621:    - conflicting requests
DEBUG util.py:621:    - nothing provides (crate(packed_simd/default) >= 0.3.0 with crate(packed_simd/default) < 0.4.0) needed by rust-rand+simd_support-devel-0.7.3-2.fc33.noarch
DEBUG util.py:621:    - nothing provides (crate(packed_simd/into_bits) >= 0.3.0 with crate(packed_simd/into_bits) < 0.4.0) needed by rust-rand+simd_support-devel-0.7.3-2.fc33.noarch

TLDR crate(rand/nightly) needs crate(rand/simd_support) which needs crate(packed_simd/default)

so you need to package packed_simd.

Comment 4 Peter Robinson 2020-07-21 17:58:03 UTC
> DEBUG util.py:621:   Problem 2: package
> rust-num-bigint-dig+nightly-devel-0.6.0-2.fc33.noarch requires
> (crate(rand/nightly) >= 0.7.0 with crate(rand/nightly) < 0.8.0), but none of
> the providers can be installed
> DEBUG util.py:621:    - package rust-rand+nightly-devel-0.7.3-2.fc33.noarch
> requires crate(rand/simd_support) = 0.7.3, but none of the providers can be
> installed
> DEBUG util.py:621:    - conflicting requests
> DEBUG util.py:621:    - nothing provides (crate(packed_simd/default) >=
> 0.3.0 with crate(packed_simd/default) < 0.4.0) needed by
> rust-rand+simd_support-devel-0.7.3-2.fc33.noarch
> DEBUG util.py:621:    - nothing provides (crate(packed_simd/into_bits) >=
> 0.3.0 with crate(packed_simd/into_bits) < 0.4.0) needed by
> rust-rand+simd_support-devel-0.7.3-2.fc33.noarch
> 
> TLDR crate(rand/nightly) needs crate(rand/simd_support) which needs
> crate(packed_simd/default)

That looks like that rust-rand package is already broken and unrelated to this review?
dnf install rust-rand+nightly-devel
Last metadata expiration check: 1:05:33 ago on Tue 21 Jul 2020 16:50:49 UTC.
Error: 
 Problem: package rust-rand+nightly-devel-0.7.3-2.fc33.noarch requires crate(rand/simd_support) = 0.7.3, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(packed_simd/default) >= 0.3.0 with crate(packed_simd/default) < 0.4.0) needed by rust-rand+simd_support-devel-0.7.3-2.fc33.noarch
  - nothing provides (crate(packed_simd/into_bits) >= 0.3.0 with crate(packed_simd/into_bits) < 0.4.0) needed by rust-rand+simd_support-devel-0.7.3-2.fc33.noarch

Comment 5 Peter Robinson 2020-07-21 18:10:15 UTC
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47578760

Comment 7 Robert-André Mauchin 🐧 2020-07-21 18:23:00 UTC
Yeah my bad it's optional

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 8 Gwyn Ciesla 2020-07-21 18:48:10 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-num-bigint-dig


Note You need to log in before you can comment on or make changes to this bug.