Bug 1859386

Summary:	OCS 4.4: [DDF] Values for cpu & mem in storagecluster can have quotes to support fresh install on OCP 4.5 as well
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Direct Docs Feedback <ddf-bot>
Component:	documentation	Assignee:	Erin Donnelly <edonnell>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Neha Berry <nberry>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.5	CC:	aclewett, asriram, bkunal, edonnell, jelopez, kbader, nberry, ocs-bugs, orit.was, owasserm, pbalogh
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-20 15:25:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Direct Docs Feedback 2020-07-21 21:13:09 UTC

Values for cpu & mem in storagecluster must have quotes

Reported by: aclewett

https://access.redhat.com/documentation/en-us/red_hat_openshift_container_storage/4.4/html/deploying_openshift_container_storage/deploying-openshift-container-storage-using-local-storage-devices_aws-vmware#annotations:e938c4ea-aac7-42ae-bba6-42fc6dc8f465

Comment 7 Neha Berry 2020-07-28 07:44:20 UTC

Hi Annette,

We have one more BZ to track new changes in AWS LSO but there are a few differences in your suggested yaml and the one updated in BZ

can we confirm the correct yaml and keep one BZ to track changes

The one suggested here - https://bugzilla.redhat.com/show_bug.cgi?id=1858283#c6


apiVersion: ocs.openshift.io/v1
kind: StorageCluster
metadata:
  name: ocs-storagecluster
  namespace: openshift-storage
spec:
  manageNodes: false
  resources:
    mds:
      limits:
        cpu: '3'
      requests:
        cpu: '1'
  monDataDirHostPath: /var/lib/rook
  storageDeviceSets:
    - count: 2
      dataPVCTemplate:
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 2328Gi
          storageClassName: localblock
          volumeMode: Block
      name: ocs-deviceset
      placement: {}
      portable: false
      replica: 3
      resources: {}

Comment 8 Neha Berry 2020-07-28 08:11:44 UTC

@orit

Can you confirm which of https://bugzilla.redhat.com/show_bug.cgi?id=1859386#c6 and https://bugzilla.redhat.com/show_bug.cgi?id=1859386#c7 needs to be kept for documentation.

@Anjana, also once we get the confirmation, we can keep one of the 2 Bugs (Bug 1858283 or Bug 1859386) to make all the changes suggested in the AWS LSO Dpeloyment section.

Comment 17 Petr Balogh 2020-07-29 12:39:48 UTC

Based on conversation in:
http://post-office.corp.redhat.com/archives/aos-devel/2020-July/msg00361.html

The issue is with the CR on our side and not on OCP.

So this should be fixed.

Comment 21 Petr Balogh 2020-07-29 20:55:33 UTC

Hello,

as I pointed out in mail thread and was found out that this can be fixed from OCS side and was done here:
https://github.com/openshift/ocs-operator/pull/654/files

After this change will be merged and propagated to 4.5 build I think we should be OK to not have any change about string/int in our documentation as it will just accept both IIUC.

Comment 26 Neha Berry 2020-08-04 18:39:44 UTC

Thanks a lot Erin for incorporating all the comments.

Verified that the CR content matches with [1] (without quotes for limits)

Also, the following 2 lines are changed correctly under section 2.3

>>In this example, the local devices available are nvme1n1 and nvme2n1.
>>In this example, the local devices available are nvme1n1 and nvme2n1 with a size of 2.3 TiB

[1] https://gist.github.com/mmgaggle/09fe2c51689c4dda7598042cc25ae526#file-ocs-4-4-storagecluster-yaml

Hence, moving th BZ to verified state.

Comment 31 Red Hat Bugzilla 2023-09-14 06:04:10 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days