Hi Annette,

We have one more BZ to track new changes in AWS LSO but there are a few differences in your suggested yaml and the one updated in BZ

can we confirm the correct yaml and keep one BZ to track changes

The one suggested here - https://bugzilla.redhat.com/show_bug.cgi?id=1858283#c6


apiVersion: ocs.openshift.io/v1
kind: StorageCluster
metadata:
  name: ocs-storagecluster
  namespace: openshift-storage
spec:
  manageNodes: false
  resources:
    mds:
      limits:
        cpu: '3'
      requests:
        cpu: '1'
  monDataDirHostPath: /var/lib/rook
  storageDeviceSets:
    - count: 2
      dataPVCTemplate:
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 2328Gi
          storageClassName: localblock
          volumeMode: Block
      name: ocs-deviceset
      placement: {}
      portable: false
      replica: 3
      resources: {}

@orit

Can you confirm which of https://bugzilla.redhat.com/show_bug.cgi?id=1859386#c6 and https://bugzilla.redhat.com/show_bug.cgi?id=1859386#c7 needs to be kept for documentation.

@Anjana, also once we get the confirmation, we can keep one of the 2 Bugs (Bug 1858283 or Bug 1859386) to make all the changes suggested in the AWS LSO Dpeloyment section.

Based on conversation in:
http://post-office.corp.redhat.com/archives/aos-devel/2020-July/msg00361.html

The issue is with the CR on our side and not on OCP.

So this should be fixed.

Hello,

as I pointed out in mail thread and was found out that this can be fixed from OCS side and was done here:
https://github.com/openshift/ocs-operator/pull/654/files

After this change will be merged and propagated to 4.5 build I think we should be OK to not have any change about string/int in our documentation as it will just accept both IIUC.

Thanks a lot Erin for incorporating all the comments.

Verified that the CR content matches with [1] (without quotes for limits)

Also, the following 2 lines are changed correctly under section 2.3

>>In this example, the local devices available are nvme1n1 and nvme2n1.
>>In this example, the local devices available are nvme1n1 and nvme2n1 with a size of 2.3 TiB

[1] https://gist.github.com/mmgaggle/09fe2c51689c4dda7598042cc25ae526#file-ocs-4-4-storagecluster-yaml

Hence, moving th BZ to verified state.

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days