Bug 1859605

Summary:	Review Request: perl-Syntax-Keyword-Dynamically - Dynamically change the value of a variable
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Syntax-Keyword-Dynamically-0.05-2.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-28 14:23:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1859635

Description Petr Pisar 2020-07-22 15:15:40 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Dynamically/perl-Syntax-Keyword-Dynamically.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Dynamically/perl-Syntax-Keyword-Dynamically-0.05-1.fc33.src.rpm
Description:
This Perl module provides a syntax plugin that implements a single keyword,
dynamically, which alters the behavior of a scalar assignment operation.
Syntactically and semantically it is similar to the built-in Perl keyword
local, but is implemented somewhat differently to give two key advantages over
regular local: You can dynamically assign to left-value functions and
accessors, and you can "dynamically" assign to regular lexical variables.


Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-07-27 15:39:38 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Syntax-Keyword-Dynamically-0.05-1.fc33.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Syntax-Keyword-Dynamically-0.05-1.fc33.x86_64.rpm | sort | uniq -c
      1 perl(Syntax::Keyword::Dynamically) = 0.05
      1 perl-Syntax-Keyword-Dynamically = 0.05-1.fc33
      1 perl-Syntax-Keyword-Dynamically(x86-64) = 0.05-1.fc33
Binary provides are Ok.

$ rpmlint ./perl-Syntax-Keyword-Dynamically*
perl-Syntax-Keyword-Dynamically.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-Syntax-Keyword-Dynamically.x86_64: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-Syntax-Keyword-Dynamically.x86_64: E: library-not-linked-against-libc /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Dynamically/Dynamically.so
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 2 Petr Pisar 2020-07-27 15:43:29 UTC

https://pagure.io/releng/fedora-scm-requests/issue/27249

Comment 3 Gwyn Ciesla 2020-07-27 15:58:57 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-Dynamically

Comment 4 Petr Pisar 2020-07-28 07:48:58 UTC

THank you for the review and the repository. I will finish bootstrapping this package after building all circular dependencies.