Bug 1859605 - Review Request: perl-Syntax-Keyword-Dynamically - Dynamically change the value of a variable
Summary: Review Request: perl-Syntax-Keyword-Dynamically - Dynamically change the valu...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1859635
TreeView+ depends on / blocked
 
Reported: 2020-07-22 15:15 UTC by Petr Pisar
Modified: 2020-07-28 14:23 UTC (History)
2 users (show)

Fixed In Version: perl-Syntax-Keyword-Dynamically-0.05-2.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-28 14:23:45 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-07-22 15:15:40 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Dynamically/perl-Syntax-Keyword-Dynamically.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Dynamically/perl-Syntax-Keyword-Dynamically-0.05-1.fc33.src.rpm
Description:
This Perl module provides a syntax plugin that implements a single keyword,
dynamically, which alters the behavior of a scalar assignment operation.
Syntactically and semantically it is similar to the built-in Perl keyword
local, but is implemented somewhat differently to give two key advantages over
regular local: You can dynamically assign to left-value functions and
accessors, and you can "dynamically" assign to regular lexical variables.


Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-07-27 15:39:38 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Syntax-Keyword-Dynamically-0.05-1.fc33.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Syntax-Keyword-Dynamically-0.05-1.fc33.x86_64.rpm | sort | uniq -c
      1 perl(Syntax::Keyword::Dynamically) = 0.05
      1 perl-Syntax-Keyword-Dynamically = 0.05-1.fc33
      1 perl-Syntax-Keyword-Dynamically(x86-64) = 0.05-1.fc33
Binary provides are Ok.

$ rpmlint ./perl-Syntax-Keyword-Dynamically*
perl-Syntax-Keyword-Dynamically.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-Syntax-Keyword-Dynamically.x86_64: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-Syntax-Keyword-Dynamically.x86_64: E: library-not-linked-against-libc /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Dynamically/Dynamically.so
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-07-27 15:58:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-Dynamically

Comment 4 Petr Pisar 2020-07-28 07:48:58 UTC
THank you for the review and the repository. I will finish bootstrapping this package after building all circular dependencies.


Note You need to log in before you can comment on or make changes to this bug.